fix: move rendering/serialization inside try/except for API path error wrapping

devin-ai-integration[bot] · rwask · devin-ai-integration[bot] · commit eecb6c26f6f6 · 2026-03-10T21:27:56.000Z
Co-Authored-By: Ryan Waskewich &lt;ryan.waskewich@airbyte.io&gt;
diff --git a/airbyte_cdk/sources/file_based/file_types/unstructured_parser.py b/airbyte_cdk/sources/file_based/file_types/unstructured_parser.py
@@ -257,6 +257,9 @@ def _read_file(
                     format.strategy,
                     remote_file,
                 )
+                if format.output_format == "markdown_json":
+                    return json.dumps(elements)
+                return self._render_markdown(elements)
             except Exception as e:
                 # If a parser error happens during remotely processing the file, this means the file is corrupted. This case is handled by the parse_records method, so just rethrow.
                 #
@@ -268,10 +271,6 @@ def _read_file(
                     e, failure_type=FailureType.config_error
                 )
 
-            if format.output_format == "markdown_json":
-                return json.dumps(elements)
-            return self._render_markdown(elements)
-
     def _params_to_dict(
         self, params: Optional[List[APIParameterConfigModel]], strategy: str
     ) -> Dict[str, Union[str, List[str]]]:

Original file line number	Diff line number	Diff line change
`@@ -257,6 +257,9 @@ def _read_file(`
`257`	`257`	`format.strategy,`
`258`	`258`	`remote_file,`
`259`	`259`	`)`
	`260`	`+ if format.output_format == "markdown_json":`
	`261`	`+ return json.dumps(elements)`
	`262`	`+ return self._render_markdown(elements)`
`260`	`263`	`except Exception as e:`
`261`	`264`	`# If a parser error happens during remotely processing the file, this means the file is corrupted. This case is handled by the parse_records method, so just rethrow.`
`262`	`265`	`#`
`@@ -268,10 +271,6 @@ def _read_file(`
`268`	`271`	`e, failure_type=FailureType.config_error`
`269`	`272`	`)`
`270`	`273`
`271`		`- if format.output_format == "markdown_json":`
`272`		`- return json.dumps(elements)`
`273`		`- return self._render_markdown(elements)`
`274`		`-`
`275`	`274`	`def _params_to_dict(`
`276`	`275`	`self, params: Optional[List[APIParameterConfigModel]], strategy: str`
`277`	`276`	`) -> Dict[str, Union[str, List[str]]]:`