fix: scope None guard to only optional status fields (skipped)

devin-ai-integration[bot] · bot_apk · devin-ai-integration[bot] · commit eaf016af03cb · 2026-04-06T14:40:33.000Z
The generic None check could silently skip a required field that was
accidentally None. Now only fields in _OPTIONAL_ASYNC_STATUS_FIELDS
(currently just 'skipped') are allowed to be None. Required fields
(running, completed, failed, timeout) raise ValueError if None.

Co-Authored-By: bot_apk &lt;apk@cognition.ai&gt;
diff --git a/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py b/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py
@@ -3680,6 +3680,8 @@ def _get_state_delegating_stream_model(
             else model.full_refresh_stream
         )
 
+    _OPTIONAL_ASYNC_STATUS_FIELDS = {"skipped"}
+
     def _create_async_job_status_mapping(
         self, model: AsyncJobStatusMapModel, config: Config, **kwargs: Any
     ) -> Mapping[str, AsyncJobStatus]:
@@ -3690,8 +3692,12 @@ def _create_async_job_status_mapping(
                 continue
 
             if api_statuses is None:
-                # Optional fields like 'skipped' may be None when not provided
-                continue
+                if cdk_status in self._OPTIONAL_ASYNC_STATUS_FIELDS:
+                    continue
+                raise ValueError(
+                    f"Required CDK status '{cdk_status}' has no API statuses mapped. "
+                    f"Please provide at least an empty list for required status fields."
+                )
 
             for status in api_statuses:
                 if status in api_status_to_cdk_status:
