sourceview: Fix pasting multi-byte encodings (#179)

kaiw · kaiw · commit 4b6f36527396 · 2018-04-26T06:53:12.000+10:00
For this API, pygobject isn't handling string length arguments for us,
so we had to do it ourselves. Shockingly, I got it very wrong. The API
requires a UTF-8 encoded string (which pygobject transparently encoded
for us) but the length arg has to be the bytestring length, not the
unicode codepoint length, which is what we were previously passing
along.
diff --git a/meld/sourceview.py b/meld/sourceview.py
@@ -170,7 +170,10 @@ def do_paste_clipboard(self, *args):
         # contain GtkTextTags, by requesting and setting plain text.
 
         def text_received_cb(clipboard, text, *user_data):
-            clipboard.set_text(text, len(text))
+            # Manual encoding is required here, or the length will be
+            # incorrect, and the API requires a UTF-8 bytestring.
+            utf8_text = text.encode('utf-8')
+            clipboard.set_text(text, len(utf8_text))
             self.get_buffer().paste_clipboard(
                 clipboard, None, self.get_editable())
 
