Refactor the gconf testing slightly

kaiw · kaiw · commit 3316df640b95 · 2013-08-30T07:08:53.000+10:00
diff --git a/meld/util/prefs.py b/meld/util/prefs.py
@@ -269,22 +269,21 @@ def __str__(self):
         return "\n".join(prefs_entries)
 
 
+force_ini = os.path.exists(
+    os.path.join(glib.get_user_config_dir(), 'meld', 'use-rc-prefs'))
+skip_gconf = sys.platform == 'win32' or force_ini
 # Prefer gconf, falling back to configparser
-Preferences = None
-
-if sys.platform != 'win32' and not os.path.exists(os.path.join(glib.get_user_config_dir(), 'meld', 'use-rc-prefs')):
-    try:
-        import gconf
-        # Verify that gconf is actually working (bgo#666136)
-        client = gconf.client_get_default()
-        key = '/apps/meld/gconf-test'
-        client.set_int(key, os.getpid())
-        client.unset(key)
-        Preferences = GConfPreferences
-    except (ImportError, glib.GError):
-        pass
-
-if Preferences == None:
+try:
+    if skip_gconf:
+        raise ImportError
+    import gconf
+    # Verify that gconf is actually working (bgo#666136)
+    client = gconf.client_get_default()
+    key = '/apps/meld/gconf-test'
+    client.set_int(key, os.getpid())
+    client.unset(key)
+    Preferences = GConfPreferences
+except (ImportError, glib.GError):
     try:
         import configparser
     except ImportError:
