Moved inplace add and multiply methods from UserString to MutableString.

rhettinger · rhettinger · commit b5812ed2ab1a · 2002-08-09T01:37:06.000Z
Closes SF Bug #592573 where inplace add mutated a UserString. Added unittests to verify the bug is cleared. git-svn-id: http://svn.python.org/projects/python/trunk@28089 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Lib/UserString.py b/Lib/UserString.py
@@ -52,20 +52,9 @@ def __radd__(self, other):
             return self.__class__(other + self.data)
         else:
             return self.__class__(str(other) + self.data)
-    def __iadd__(self, other):
-        if isinstance(other, UserString):
-            self.data += other.data
-        elif isinstance(other, StringTypes):
-            self.data += other
-        else:
-            self.data += str(other)
-        return self
     def __mul__(self, n):
         return self.__class__(self.data*n)
     __rmul__ = __mul__
-    def __imul__(self, n):
-        self.data *= n
-        return self
 
     # the following methods are defined in alphabetical order:
     def capitalize(self): return self.__class__(self.data.capitalize())
@@ -168,6 +157,17 @@ def __delslice__(self, start, end):
         self.data = self.data[:start] + self.data[end:]
     def immutable(self):
         return UserString(self.data)
+    def __iadd__(self, other):
+        if isinstance(other, UserString):
+            self.data += other.data
+        elif isinstance(other, StringTypes):
+            self.data += other
+        else:
+            self.data += str(other)
+        return self
+    def __imul__(self, n):
+        self.data *= n
+        return self
 
 if __name__ == "__main__":
     # execute the regression test to stdout, if called as a script:
diff --git a/Lib/test/string_tests.py b/Lib/test/string_tests.py
@@ -314,3 +314,9 @@ def run_contains_tests(test):
     test('__contains__', 'asdf', True, 'asdf') # vereq('asdf' in 'asdf', True)
     test('__contains__', 'asd', False, 'asdf') # vereq('asdf' in 'asd', False)
     test('__contains__', '', False, 'asdf')    # vereq('asdf' in '', False)
+
+def run_inplace_tests(constructor):
+    # Verify clearing of SF bug #592573
+    s = t = constructor('abc')
+    s += constructor('def')
+    verify(s != t, 'in-place concatenate should create a new object')
diff --git a/Lib/test/test_string.py b/Lib/test/test_string.py
@@ -52,6 +52,7 @@ def __repr__(self):
 string_tests.run_module_tests(test)
 string_tests.run_method_tests(test)
 string_tests.run_contains_tests(test)
+string_tests.run_inplace_tests(str)
 
 string.whitespace
 string.lowercase
diff --git a/Lib/test/test_userstring.py b/Lib/test/test_userstring.py
@@ -42,3 +42,4 @@ def test(methodname, input, output, *args):
 
 string_tests.run_method_tests(test)
 string_tests.run_contains_tests(test)
+string_tests.run_inplace_tests(UserString)

Original file line number	Diff line number	Diff line change
`@@ -42,3 +42,4 @@ def test(methodname, input, output, *args):`
`42`	`42`
`43`	`43`	`string_tests.run_method_tests(test)`
`44`	`44`	`string_tests.run_contains_tests(test)`
	`45`	`+string_tests.run_inplace_tests(UserString)`