Closure can't be NULL at this point since we know it's a tuple.

neal.norwitz · neal.norwitz · commit 11a202859fd0 · 2006-07-27T03:55:39.000Z
Reported by Klocwork # 74. git-svn-id: http://svn.python.org/projects/python/trunk@50857 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Objects/funcobject.c b/Objects/funcobject.c
@@ -141,7 +141,7 @@ PyFunction_SetClosure(PyObject *op, PyObject *closure)
 	if (closure == Py_None)
 		closure = NULL;
 	else if (PyTuple_Check(closure)) {
-		Py_XINCREF(closure);
+		Py_INCREF(closure);
 	}
 	else {
 		PyErr_Format(PyExc_SystemError, 

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ PyFunction_SetClosure(PyObject op, PyObject closure)`
`141`	`141`	`if (closure == Py_None)`
`142`	`142`	`closure = NULL;`
`143`	`143`	`else if (PyTuple_Check(closure)) {`
`144`		`- Py_XINCREF(closure);`
	`144`	`+ Py_INCREF(closure);`
`145`	`145`	`}`
`146`	`146`	`else {`
`147`	`147`	`PyErr_Format(PyExc_SystemError,`