Clean up engineering setting debts. (microsoft#165)

yaohaizh · web-flow · commit 67d059d8d828 · 2018-04-02T09:55:55.000+08:00
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java
@@ -56,7 +56,7 @@ public class DebugUtility {
 
     /**
      * Launch a debuggee in suspend mode.
-     * @see {@link #launch(VirtualMachineManager, String, String, String, String, String)}
+     * @see #launch(VirtualMachineManager, String, String, String, String, String)
      */
     public static IDebugSession launch(VirtualMachineManager vmManager,
             String mainClass,
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/UsageDataStore.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/UsageDataStore.java
@@ -40,7 +40,7 @@ private static final class SingletonHolder {
     }
 
     /**
-     * Fetch all pending user data records
+     * Fetch all pending user data records.
      * @return List of user data Object.
      */
     public synchronized Object[] fetchAll() {
diff --git a/com.microsoft.java.debug.plugin/META-INF/MANIFEST.MF b/com.microsoft.java.debug.plugin/META-INF/MANIFEST.MF
@@ -14,7 +14,9 @@ Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.jdt.debug,
  org.eclipse.jdt.core,
  org.eclipse.jdt.ls.core,
- org.eclipse.jdt.launching
+ org.eclipse.jdt.launching,
+ com.google.gson;bundle-version="2.7.0",
+ org.apache.commons.lang3;bundle-version="3.1.0"
 Bundle-ClassPath: lib/gson-2.7.jar,
  .,
  lib/rxjava-2.1.1.jar,
diff --git a/com.microsoft.java.debug.plugin/pom.xml b/com.microsoft.java.debug.plugin/pom.xml
@@ -27,11 +27,6 @@
                 <artifactId>maven-dependency-plugin</artifactId>
                 <configuration>
                     <artifactItems>
-                        <artifactItem>
-                            <groupId>com.google.code.gson</groupId>
-                            <artifactId>gson</artifactId>
-                            <version>2.7</version>
-                        </artifactItem>
                         <artifactItem>
                             <groupId>io.reactivex.rxjava2</groupId>
                             <artifactId>rxjava</artifactId>
@@ -42,11 +37,6 @@
                             <artifactId>reactive-streams</artifactId>
                             <version>1.0.0</version>
                         </artifactItem>
-                        <artifactItem>
-                            <groupId>org.apache.commons</groupId>
-                            <artifactId>commons-lang3</artifactId>
-                            <version>3.6</version>
-                        </artifactItem>
                         <artifactItem>
                             <groupId>commons-io</groupId>
                             <artifactId>commons-io</artifactId>

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ private static final class SingletonHolder {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`/**`
`43`		`- * Fetch all pending user data records`
	`43`	`+ * Fetch all pending user data records.`
`44`	`44`	`* @return List of user data Object.`
`45`	`45`	`*/`
`46`	`46`	`public synchronized Object[] fetchAll() {`