Fix the perf issue when debug idea (microsoft#42)

andxu · web-flow · commit 069b7527bf82 · 2017-09-21T09:39:53.000+08:00
diff --git a/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java b/com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/adapter/handler/StackTraceRequestHandler.java
@@ -16,6 +16,8 @@
 import java.util.Arrays;
 import java.util.List;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.microsoft.java.debug.core.DebugUtility;
 import com.microsoft.java.debug.core.adapter.AdapterUtils;
 import com.microsoft.java.debug.core.adapter.IDebugAdapterContext;
@@ -109,11 +111,13 @@ private Types.Source convertDebuggerSourceToClient(Location location, IDebugAdap
 
         final String finalRelativeSourcePath = relativeSourcePath;
         // use a lru cache for better performance
-        String uri = context.getSourceLookupCache().computeIfAbsent(fullyQualifiedName, key ->
-            context.getProvider(ISourceLookUpProvider.class).getSourceFileURI(key, finalRelativeSourcePath)
-        );
+        String uri = context.getSourceLookupCache().computeIfAbsent(fullyQualifiedName, key -> {
+            String fromProvider = context.getProvider(ISourceLookUpProvider.class).getSourceFileURI(key, finalRelativeSourcePath);
+            // avoid return null which will cause the compute function executed again
+            return StringUtils.isBlank(fromProvider) ? "" : fromProvider;
+        });
 
-        if (uri != null) {
+        if (!StringUtils.isBlank(uri)) {
             String clientPath = AdapterUtils.convertPath(uri, context.isDebuggerPathsAreUri(), context.isClientPathsAreUri());
             if (uri.startsWith("file:")) {
                 return new Types.Source(sourceName, clientPath, 0);
