apply was a crap method name

hjwp · hjwp · commit db171061a262 · 2019-02-08T16:09:46.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -30,7 +30,7 @@ class Order(SkuLines):
 
     def allocate(self, stock, shipments):
         self.allocation = Allocation.for_order(self, stock, shipments)
-        self.allocation.apply()
+        self.allocation.decrement_source_quantities()
 
 
 @dataclass
@@ -39,7 +39,7 @@ class Stock(SkuLines):
     def can_allocate(self, line: OrderLine):
         return line.sku in self.skus and self.quantities[line.sku] > line.quantity
 
-    def allocate(self, sku, quantity):
+    def decrement_quantity(self, sku, quantity):
         for line in self.lines:
             if line.sku == sku:
                 line.quantity -= quantity
@@ -61,6 +61,9 @@ class AllocationLine:
     quantity: int
     source: Stock
 
+    def decrement_source_quantity(self):
+        self.source.decrement_quantity(self.sku, self.quantity)
+
 
 @dataclass
 class Allocation:
@@ -97,12 +100,8 @@ def supplement_with(self, other_allocation):
             l for l in other_allocation.lines if l.sku not in self.skus
         )
 
-    @property
-    def is_complete(self):
-        return self.skus == self.order.skus
-
-    def apply(self):
+    def decrement_source_quantities(self):
         for line in self.lines:
-            line.source.allocate(line.sku, line.quantity)
+            line.decrement_source_quantity()
 
 
