fix a few remaining places where stock was a list

hjwp · hjwp · commit 92a67f439d80 · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -5,18 +5,16 @@ def __init__(self, id, eta, lines):
         super().__init__(lines)
 
 
-def skus(thing):
-    try:
-        return {line.sku for line in thing}
-    except:
-        return thing.keys()
+def skus(d):
+    return d.keys()
 
 
 def allocate_line(sku, quantity, source, allocations):
     if source.get(sku, 0) > quantity:
         source[sku] -= quantity
         allocations[sku] = getattr(source, 'id', 'STOCK')
 
+
 def allocate_to(order, source):
     allocations = {}
     for sku, quantity in order.items():
diff --git a/test_allocation.py b/test_allocation.py
@@ -28,7 +28,7 @@ def test_can_allocate_to_shipment():
         'a-sku': 1000
     })
 
-    allocations = allocate(order, stock=[], shipments=[shipment])
+    allocations = allocate(order, stock={}, shipments=[shipment])
 
     assert allocations['a-sku'] == shipment.id
     assert shipment['a-sku'] == 990
@@ -57,7 +57,7 @@ def test_can_allocate_to_correct_shipment():
         'sku2': 1000,
     })
 
-    allocations = allocate(order, stock=[], shipments=[shipment1, shipment2])
+    allocations = allocate(order, stock={}, shipments=[shipment1, shipment2])
 
     assert allocations['sku2'] == shipment2.id
     assert shipment1['sku1'] == 1000
@@ -96,7 +96,7 @@ def test_can_allocate_multiple_lines_to_shipment():
         'sku2': 1000,
     })
 
-    allocations = allocate(order, [], shipments=[shipment])
+    allocations = allocate(order, stock={}, shipments=[shipment])
 
     assert allocations['sku1'] == shipment.id
     assert allocations['sku2'] == shipment.id
@@ -213,7 +213,7 @@ def test_cannot_allocate_if_insufficent_quantity_in_shipment():
         'a-sku': 5,
     })
 
-    allocations = allocate(order, stock=[], shipments=[shipment])
+    allocations = allocate(order, stock={}, shipments=[shipment])
 
     assert 'a-sku' not in allocations
 
