inline a dict creation

hjwp · hjwp · commit 91d8e0f403ba · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -24,14 +24,16 @@ def allocate_to(order, source):
     return allocations
 
 
-def allocate_to_sources(order, sources, allocations):
+def allocate_to_sources(order, sources):
+    allocations = {}
     for sku, quantity in order.items():
         if sku in allocations:
             continue
         for source in sources:
             allocate_line(sku, quantity, source, allocations)
             if sku in allocations:
                 break
+    return allocations
 
 
 
@@ -45,6 +47,4 @@ def allocate(order, stock, shipments):
         if skus(order) <= skus(shipment):
             return allocate_to(order, shipment)
 
-    allocations = {}
-    allocate_to_sources(order, [stock] + shipments, allocations)
-    return allocations
+    return allocate_to_sources(order, [stock] + shipments)
