adap tests etc

hjwp · hjwp · commit 77ad02481a37 · 2020-01-09T22:11:21.000Z
diff --git a/src/allocation/domain/model.py b/src/allocation/domain/model.py
@@ -18,6 +18,15 @@ def allocate(line: OrderLine, batches: List[Batch]) -> str:
     except StopIteration:
         raise OutOfStock(f'Out of stock for sku {line.sku}')
 
+class Product:
+    ''' dummy implementation, fixme'''
+
+    def __init__(self, *args, **kwargs):
+        self.batches = kwargs.get('batches')
+
+    def allocate(self, line):
+        return allocate(line,  self.batches)
+
 
 @dataclass(unsafe_hash=True)
 class OrderLine:
diff --git a/src/allocation/service_layer/unit_of_work.py b/src/allocation/service_layer/unit_of_work.py
@@ -27,7 +27,6 @@ def rollback(self):
         raise NotImplementedError
 
 
-
 DEFAULT_SESSION_FACTORY = sessionmaker(bind=create_engine(
     config.get_postgres_uri(),
     isolation_level="SERIALIZABLE",
diff --git a/tests/integration/test_uow.py b/tests/integration/test_uow.py
@@ -10,10 +10,9 @@
 
 
 def insert_batch(session, ref, sku, qty, eta, product_version=1):
-    session.execute(
-        'INSERT INTO products (sku, version_number) VALUES (:sku, :version)',
-        dict(sku=sku, version=product_version),
-    )
+    # session.execute(
+    #     'INSERT INTO products ...?
+    # )
     session.execute(
         'INSERT INTO batches (reference, sku, _purchased_quantity, eta)'
         ' VALUES (:ref, :sku, :qty, :eta)',
@@ -88,6 +87,7 @@ def try_to_allocate(orderid, sku, exceptions):
         exceptions.append(e)
 
 
+@pytest.mark.skip('do this for an advanced challenge')
 def test_concurrent_updates_to_version_are_not_allowed(postgres_session_factory):
     sku, batch = random_sku(), random_batchref()
     session = postgres_session_factory()
diff --git a/tests/unit/test_product.py b/tests/unit/test_product.py
@@ -50,6 +50,7 @@ def test_raises_out_of_stock_exception_if_cannot_allocate():
         product.allocate(OrderLine('order2', 'SMALL-FORK', 1))
 
 
+@pytest.mark.skip
 def test_increments_version_number():
     line = OrderLine('oref', "SCANDI-PEN", 10)
     product = Product(sku="SCANDI-PEN", batches=[Batch('b1', "SCANDI-PEN", 100, eta=None)])
diff --git a/tests/unit/test_services.py b/tests/unit/test_services.py
@@ -5,14 +5,17 @@
 
 class FakeRepository(repository.AbstractRepository):
 
-    def __init__(self, products):
-        self._products = set(products)
+    def __init__(self, batches):
+        self._batches = set(batches)
 
-    def add(self, product):
-        self._products.add(product)
+    def add(self, batch):
+        self._batches.add(batch)
 
     def get(self, sku):
-        return next((p for p in self._products if p.sku == sku), None)
+        return next((p for p in self._batches if p.sku == sku), None)
+
+    def list(self):
+        return list(self._batches)
 
 
 class FakeUnitOfWork(unit_of_work.AbstractUnitOfWork):
