api tests no longer need hardcoded sql fixture [api_tests_with_no_sql]

hjwp · hjwp · commit 4c913d675d77 · 2020-01-08T20:41:36.000Z
diff --git a/conftest.py b/conftest.py
@@ -64,45 +64,6 @@ def postgres_session(postgres_db):
     clear_mappers()
 
 
-@pytest.fixture
-def add_stock(postgres_session):
-    batches_added = set()
-    skus_added = set()
-
-    def _add_stock(lines):
-        for ref, sku, qty, eta in lines:
-            postgres_session.execute(
-                'INSERT INTO batches (reference, sku, _purchased_quantity, eta)'
-                ' VALUES (:ref, :sku, :qty, :eta)',
-                dict(ref=ref, sku=sku, qty=qty, eta=eta),
-            )
-            [[batch_id]] = postgres_session.execute(
-                'SELECT id FROM batches WHERE reference=:ref AND sku=:sku',
-                dict(ref=ref, sku=sku),
-            )
-            batches_added.add(batch_id)
-            skus_added.add(sku)
-        postgres_session.commit()
-
-    yield _add_stock
-
-    for batch_id in batches_added:
-        postgres_session.execute(
-            'DELETE FROM allocations WHERE batch_id=:batch_id',
-            dict(batch_id=batch_id),
-        )
-        postgres_session.execute(
-            'DELETE FROM batches WHERE id=:batch_id',
-            dict(batch_id=batch_id),
-        )
-    for sku in skus_added:
-        postgres_session.execute(
-            'DELETE FROM order_lines WHERE sku=:sku',
-            dict(sku=sku),
-        )
-        postgres_session.commit()
-
-
 @pytest.fixture
 def restart_api():
     (Path(__file__).parent / 'flask_app.py').touch()
diff --git a/test_api.py b/test_api.py
@@ -17,22 +17,31 @@ def random_orderid(name=''):
     return f'order-{name}-{random_suffix()}'
 
 
+def post_to_add_batch(ref, sku, qty, eta):
+    url = config.get_api_url()
+    r = requests.post(
+        f'{url}/add_batch',
+        json={'ref': ref, 'sku': sku, 'qty': qty, 'eta': eta}
+    )
+    assert r.status_code == 201
+
+
+@pytest.mark.usefixtures('postgres_db')
 @pytest.mark.usefixtures('restart_api')
-def test_happy_path_returns_201_and_allocated_batch(add_stock):
+def test_happy_path_returns_201_and_allocated_batch():
     sku, othersku = random_sku(), random_sku('other')
     batch1, batch2, batch3 = random_batchref(1), random_batchref(2), random_batchref(3)
-    add_stock([
-        (batch1, sku, 100, '2011-01-02'),
-        (batch2, sku, 100, '2011-01-01'),
-        (batch3, othersku, 100, None),
-    ])
+    post_to_add_batch(batch1, sku, 100, '2011-01-02')
+    post_to_add_batch(batch2, sku, 100, '2011-01-01')
+    post_to_add_batch(batch3, othersku, 100, None)
     data = {'orderid': random_orderid(), 'sku': sku, 'qty': 3}
     url = config.get_api_url()
     r = requests.post(f'{url}/allocate', json=data)
     assert r.status_code == 201
     assert r.json()['batchref'] == batch2
 
 
+@pytest.mark.usefixtures('postgres_db')
 @pytest.mark.usefixtures('restart_api')
 def test_unhappy_path_returns_400_and_error_message():
     unknown_sku, orderid = random_sku(), random_orderid()
