get rid of shipment id

hjwp · hjwp · commit 4945d35d8af2 · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -1,6 +1,5 @@
 class Shipment(dict):
-    def __init__(self, id, eta, lines):
-        self.id = id
+    def __init__(self, eta, lines):
         self.eta = eta
         super().__init__(lines)
 
diff --git a/test_allocation.py b/test_allocation.py
@@ -24,7 +24,7 @@ def test_can_allocate_to_stock():
 
 def test_can_allocate_to_shipment():
     order = {'a-sku': 10}
-    shipment = Shipment(id='shipment-id', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'a-sku': 1000
     })
 
@@ -37,7 +37,7 @@ def test_can_allocate_to_shipment():
 def test_ignores_irrelevant_stock():
     order = {'sku1': 10}
     stock = {'sku2': 1000}
-    shipment = Shipment(id='shipment-id', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'sku1': 1000,
     })
 
@@ -50,10 +50,10 @@ def test_ignores_irrelevant_stock():
 
 def test_can_allocate_to_correct_shipment():
     order = {'sku2': 10}
-    shipment1 = Shipment('shipment1', eta=date.today(), lines={
+    shipment1 = Shipment(eta=date.today(), lines={
         'sku1': 1000,
     })
-    shipment2 = Shipment('shipment2', eta=date.today(), lines={
+    shipment2 = Shipment(eta=date.today(), lines={
         'sku2': 1000,
     })
 
@@ -67,7 +67,7 @@ def test_can_allocate_to_correct_shipment():
 def test_allocates_to_stock_in_preference_to_shipment():
     order = {'sku1': 10}
     stock = {'sku1': 1000}
-    shipment = Shipment('shipment1', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'sku1': 1000,
     })
 
@@ -91,7 +91,7 @@ def test_can_allocate_multiple_lines_to_wh():
 
 def test_can_allocate_multiple_lines_to_shipment():
     order = {'sku1': 5, 'sku2': 10}
-    shipment = Shipment('shipment1', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'sku1': 1000,
         'sku2': 1000,
     })
@@ -106,7 +106,7 @@ def test_can_allocate_multiple_lines_to_shipment():
 
 def test_can_allocate_to_both():
     order = {'sku1': 5, 'sku2': 10}
-    shipment = Shipment('shipment1', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'sku2': 1000,
     })
     stock = {'sku1': 1000}
@@ -121,7 +121,7 @@ def test_can_allocate_to_both():
 
 def test_can_allocate_to_both_preferring_stock():
     order = {'sku1': 1, 'sku2': 2, 'sku3': 3, 'sku4': 4}
-    shipment = Shipment('shipment1', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'sku1': 1000,
         'sku2': 1000,
         'sku3': 1000,
@@ -143,7 +143,7 @@ def test_can_allocate_to_both_preferring_stock():
 
 def test_mixed_allocations_are_avoided_if_possible():
     order = {'sku1': 10, 'sku2': 10}
-    shipment = Shipment('shipment1', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'sku1': 1000,
         'sku2': 1000,
     })
@@ -157,12 +157,12 @@ def test_mixed_allocations_are_avoided_if_possible():
 
 def test_prefer_allocating_to_earlier_shipment():
     order = {'sku1': 10, 'sku2': 10}
-    shipment1 = Shipment('shipment1', eta=date.today(), lines={
+    shipment1 = Shipment(eta=date.today(), lines={
         'sku1': 1000,
         'sku2': 1000,
     })
     tomorrow = date.today() + timedelta(days=1)
-    shipment2 = Shipment('shipment2', eta=tomorrow, lines={
+    shipment2 = Shipment(eta=tomorrow, lines={
         'sku1': 1000,
         'sku2': 1000,
     })
@@ -176,16 +176,16 @@ def test_prefer_allocating_to_earlier_shipment():
 
 def test_prefer_allocating_to_earlier_even_if_multiple_shipments():
     order = {'sku1': 10, 'sku2': 10, 'sku3': 10}
-    shipment1 = Shipment(id='shipment1', eta=date.today(), lines={
+    shipment1 = Shipment(eta=date.today(), lines={
         'sku1': 1000,
     })
     tomorrow = date.today() + timedelta(days=1)
-    shipment2 = Shipment(id='shipment2', eta=tomorrow, lines={
+    shipment2 = Shipment(eta=tomorrow, lines={
         'sku2': 1000,
         'sku3': 1000,
     })
     later = tomorrow + timedelta(days=1)
-    shipment3 = Shipment(id='shipment3', eta=later, lines={
+    shipment3 = Shipment(eta=later, lines={
         'sku2': 1000,
         'sku3': 1000,
     })
@@ -209,7 +209,7 @@ def test_cannot_allocate_if_insufficent_quantity_in_stock():
 
 def test_cannot_allocate_if_insufficent_quantity_in_shipment():
     order = {'a-sku': 10}
-    shipment = Shipment(id='shipment-id', eta=date.today(), lines={
+    shipment = Shipment(eta=date.today(), lines={
         'a-sku': 5,
     })
 
