remove polymorphism from allocate_to

hjwp · hjwp · commit 4073e41a53f2 · 2019-02-05T10:15:06.000Z
diff --git a/domain_model.py b/domain_model.py
@@ -29,17 +29,10 @@ def skus(thing):
 
 
 def allocate_to(line, allocation, source):
-    try:
-        if source.get(line.sku, 0) > line.quantity:
-            line.allocation = allocation
-            source[line.sku] -= line.quantity
-
-    except AttributeError:
-        for source_line in source:
-            if source_line.sku == line.sku and source_line.quantity > line.quantity:
-                line.allocation = allocation
-                source_line.quantity -= line.quantity
-                return
+    if source.get(line.sku, 0) > line.quantity:
+        line.allocation = allocation
+        source[line.sku] -= line.quantity
+
 
 def allocate_to_stock(order, stock):
     for line in order:
diff --git a/test_allocation.py b/test_allocation.py
@@ -216,7 +216,7 @@ def test_prefer_allocating_to_earlier_even_if_multiple_shipments():
         'sku2': 1000,
         'sku3': 1000,
     })
-    stock = []
+    stock = {}
 
     allocate(order, stock, shipments=[shipment3, shipment2, shipment1])
 
