modify allocate handler to no longer return anything

hjwp · hjwp · commit 40148afd59e0 · 2020-02-21T12:15:28.000Z
diff --git a/src/allocation/service_layer/handlers.py b/src/allocation/service_layer/handlers.py
@@ -27,15 +27,14 @@ def add_batch(
 
 def allocate(
         cmd: commands.Allocate, uow: unit_of_work.AbstractUnitOfWork
-) -> str:
+):
     line = OrderLine(cmd.orderid, cmd.sku, cmd.qty)
     with uow:
         product = uow.products.get(sku=line.sku)
         if product is None:
             raise InvalidSku(f'Invalid sku {line.sku}')
-        batchref = product.allocate(line)
+        product.allocate(line)
         uow.commit()
-        return batchref
 
 
 def change_batch_quantity(
diff --git a/tests/unit/test_handlers.py b/tests/unit/test_handlers.py
@@ -73,10 +73,9 @@ def test_allocates(self):
         messagebus.handle(
             commands.CreateBatch("batch1", "COMPLICATED-LAMP", 100, None), uow
         )
-        results = messagebus.handle(
+        messagebus.handle(
             commands.Allocate("o1", "COMPLICATED-LAMP", 10), uow
         )
-        assert results.pop(0) == "batch1"
         [batch] = uow.products.get("COMPLICATED-LAMP").batches
         assert batch.available_quantity == 90
 

Original file line number	Diff line number	Diff line change
`@@ -73,10 +73,9 @@ def test_allocates(self):`
`73`	`73`	`messagebus.handle(`
`74`	`74`	`commands.CreateBatch("batch1", "COMPLICATED-LAMP", 100, None), uow`
`75`	`75`	`)`
`76`		`- results = messagebus.handle(`
	`76`	`+ messagebus.handle(`
`77`	`77`	`commands.Allocate("o1", "COMPLICATED-LAMP", 10), uow`
`78`	`78`	`)`
`79`		`- assert results.pop(0) == "batch1"`
`80`	`79`	`[batch] = uow.products.get("COMPLICATED-LAMP").batches`
`81`	`80`	`assert batch.available_quantity == 90`
`82`	`81`