fixture function for batches [services_factory_function]

hjwp · hjwp · commit 1e1f2381e348 · 2021-02-24T10:04:07.000Z
diff --git a/tests/unit/test_services.py b/tests/unit/test_services.py
@@ -5,6 +5,10 @@
 
 
 class FakeRepository(repository.AbstractRepository):
+    @staticmethod
+    def for_batch(ref, sku, qty, eta=None):
+        return FakeRepository([model.Batch(ref, sku, qty, eta),])
+
     def __init__(self, batches):
         self._batches = set(batches)
 
@@ -26,25 +30,19 @@ def commit(self):
 
 
 def test_returns_allocation():
-    batch = model.Batch("batch1", "COMPLICATED-LAMP", 100, eta=None)
-    repo = FakeRepository([batch])
-
+    repo = FakeRepository.for_batch("batch1", "COMPLICATED-LAMP", 100, eta=None)
     result = services.allocate("o1", "COMPLICATED-LAMP", 10, repo, FakeSession())
     assert result == "batch1"
 
 
 def test_error_for_invalid_sku():
-    batch = model.Batch("b1", "AREALSKU", 100, eta=None)
-    repo = FakeRepository([batch])
-
+    repo = FakeRepository.for_batch("b1", "AREALSKU", 100, eta=None)
     with pytest.raises(services.InvalidSku, match="Invalid sku NONEXISTENTSKU"):
         services.allocate("o1", "NONEXISTENTSKU", 10, repo, FakeSession())
 
 
 def test_commits():
-    batch = model.Batch("b1", "OMINOUS-MIRROR", 100, eta=None)
-    repo = FakeRepository([batch])
+    repo = FakeRepository.for_batch("b1", "OMINOUS-MIRROR", 100, eta=None)
     session = FakeSession()
-
     services.allocate("o1", "OMINOUS-MIRROR", 10, repo, session)
     assert session.committed is True
