putting it in the services layer isn't lovely either [email_in_services]

hjwp · hjwp · commit 08cb29f82ce7 · 2019-07-18T22:12:32.000+01:00
diff --git a/src/allocation/model.py b/src/allocation/model.py
@@ -3,7 +3,6 @@
 from datetime import date
 from typing import Optional, List, Set
 from allocation import exceptions
-from allocation import email
 
 
 class Product:
@@ -22,7 +21,6 @@ def allocate(self, line: OrderLine) -> str:
             self.version_number += 1
             return batch.reference
         except StopIteration:
-            email.send_mail('stock@made.com', f'Out of stock for {line.sku}')
             raise exceptions.OutOfStock(f'Out of stock for sku {line.sku}')
 
 
diff --git a/src/allocation/services.py b/src/allocation/services.py
@@ -2,7 +2,7 @@
 from typing import Optional
 from datetime import date
 
-from allocation import exceptions, model, unit_of_work
+from allocation import email, exceptions, model, unit_of_work
 from allocation.model import OrderLine
 
 
@@ -28,6 +28,10 @@ def allocate(
         product = uow.products.get(sku=line.sku)
         if product is None:
             raise exceptions.InvalidSku(f'Invalid sku {line.sku}')
-        batchref = product.allocate(line)
-        uow.commit()
-    return batchref
+        try:
+            batchref = product.allocate(line)
+            uow.commit()
+            return batchref
+        except exceptions.OutOfStock:
+            email.send_mail('stock@made.com', f'Out of stock for {line.sku}')
+            raise
