module: coverity fixes for ESM C++

bmeck · addaleax · commit 53bf9020d1de · 2017-09-17T15:13:39.000+02:00
PR-URL: nodejs/node#15275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -325,7 +325,7 @@ inline const struct read_result read_file(uv_file file) {
 }
 struct file_check {
   bool failed = true;
-  uv_file file;
+  uv_file file = -1;
 } file_check;
 inline const struct file_check check_file(URL search,
                                           bool close = false,
@@ -461,7 +461,7 @@ URL Resolve(std::string specifier, URL* base, bool read_pkg_json) {
   } else {
     return resolve_module(specifier, base);
   }
-  return URL("");
+  UNREACHABLE();
 }
 
 void ModuleWrap::Resolve(const FunctionCallbackInfo<Value>& args) {

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ inline const struct read_result read_file(uv_file file) {`
`325`	`325`	`}`
`326`	`326`	`struct file_check {`
`327`	`327`	`bool failed = true;`
`328`		`- uv_file file;`
	`328`	`+ uv_file file = -1;`
`329`	`329`	`} file_check;`
`330`	`330`	`inline const struct file_check check_file(URL search,`
`331`	`331`	`bool close = false,`
`@@ -461,7 +461,7 @@ URL Resolve(std::string specifier, URL* base, bool read_pkg_json) {`
`461`	`461`	`} else {`
`462`	`462`	`return resolve_module(specifier, base);`
`463`	`463`	`}`
`464`		`- return URL("");`
	`464`	`+ UNREACHABLE();`
`465`	`465`	`}`
`466`	`466`
`467`	`467`	`void ModuleWrap::Resolve(const FunctionCallbackInfo<Value>& args) {`