Conversation
I checked all ERB templates in
I verified these attributes exist in Flowbite v4's source with identical occurrence counts as v3 — the data attribute API is fully backward compatible. No ERB template changes are needed. |
There was a problem hiding this comment.
this has been manually verified to be identical to https://cdn.jsdelivr.net/npm/flowbite@4.0.1/dist/flowbite.min.js
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8938 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 139 139
Lines 4045 4045
=======================================
Hits 4008 4008
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tagliala
left a comment
There was a problem hiding this comment.
I've manually tested this PR with bin/rake local server and a clean tmp/development_apps.
I do not see regressions or differences
248bc4c to
096f4db
Compare
Co-authored-by: tagliala <556268+tagliala@users.noreply.github.com>
096f4db to
1b9894a
Compare
javierjulio
left a comment
There was a problem hiding this comment.
There is a problem with on v4 where it has no modal backdrop for both the hamburger menu navigation for mobile which I think Flowbite calls the Drawer component and then a plain modal for the batch action form which is available on the user nested posts index resource. The functionality for each though is working as expected so that's good. I'm not sure if anything else besides the modal backdrop is missing.
Will take a second look here |
Root CauseIn Flowbite v3 (3.1.2), the modal and drawer backdrop classes used hardcoded Tailwind CSS color utilities: backdropClasses: 'bg-gray-900/50 dark:bg-gray-900/80 fixed inset-0 z-40',In Flowbite v4 (4.0.1), these were changed to use a CSS custom property (theme variable): backdropClasses: 'bg-dark-backdrop/70 fixed inset-0 z-40',The same change was made in the Drawer component: backdropClasses: 'bg-dark-backdrop/70 fixed inset-0 z-30',Why
|
| Flowbite v3 | Flowbite v4 | |
|---|---|---|
| Modal backdrop | bg-gray-900/50 dark:bg-gray-900/80 |
bg-dark-backdrop/70 |
| Drawer backdrop | bg-gray-900/50 dark:bg-gray-900/80 |
bg-dark-backdrop/70 |
| Requires theme CSS? | No (hardcoded colors) | Yes (--color-dark-backdrop) |
The PR #8938 correctly vendored the new JS, but missed that v4 now depends on CSS theme variables that weren't previously needed. The --color-dark-backdrop variable (and potentially other theme variables) must be provided by ActiveAdmin for the backdrop to render.
|
@javierjulio it is because of default themes they have introduced themes, and now The default theme, also "forces" --font-sans: 'Inter', 'ui-sans-serif', 'system-ui', '-apple-system', 'system-ui', 'Segoe UI', 'Roboto', 'Helvetica Neue', 'Arial', 'Noto Sans', 'sans-serif', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';
--font-body: 'Inter', 'ui-sans-serif', 'system-ui', '-apple-system', 'system-ui', 'Segoe UI', 'Roboto', 'Helvetica Neue', 'Arial', 'Noto Sans', 'sans-serif', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji';ad advising to @import url('https://fonts.googleapis.com/css2?family=Inter:wght@300;400;500;600;700;800&display=swap');Which is really surprising and a no-go for me, since this would introduce by default a call to external cdns and slow down the admin area I will revert to draft and find another solution |
Upgrades Flowbite from 3.1.2 to 4.0.1.
package.jsondependency andyarn.lockconfig/importmap.rbvendor/javascript/flowbite.jsfrom the v4 distFlowbite v4 maintains backward compatibility with the data attributes API (
data-dropdown-toggle,data-drawer-*,data-modal-*) used throughout the views.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.jsdelivr.net/usr/bin/curl curl -sI REDACTED(dns block)/usr/bin/curl curl -s REDACTED(dns block)/usr/bin/curl curl -svL REDACTED(dns block)flowbite.com/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.