ci: remove validate-do-not-submit check

alan-agius4 · clydin · commit ab84fc56b39e · 2021-02-03T12:18:26.000-05:00
This uses `git merge-base --fork-point master` which currently is not yielding a SHA on the patch branch. In some cases merge-base will not working as expected when base is ahead. See https://public-inbox.org/git/xmqq375okvxy.fsf@gitster.mtv.corp.google.com/T/#r3830f032d76f39b82d0ffe7f8bd77351cf634d29 This validation checks if `DO_NOT_SUBMIT` string literal has been added using `git diff`, when present validation will fail. This check is unneeded as we do not use the `DO_NOT_SUBMIT` pattern, as we typically use `wip!` commit message types.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -174,9 +174,6 @@ jobs:
             else
               echo "This build is not over a PR, nothing to do."
             fi
-      - run:
-          name: Validate "do not submit" Commits
-          command: yarn -s admin validate-do-not-submit
       - run:
           command: yarn -s admin validate --ci
 
diff --git a/scripts/validate-do-not-submit.ts b/scripts/validate-do-not-submit.ts
diff --git a/scripts/validate.ts b/scripts/validate.ts
@@ -10,7 +10,6 @@ import { logging, tags } from '@angular-devkit/core';
 import { execSync } from 'child_process';
 import templates from './templates';
 import validateBuildFiles from './validate-build-files';
-import validateDoNotSubmit from './validate-do-not-submit';
 import validateLicenses from './validate-licenses';
 import validateUserAnalytics from './validate-user-analytics';
 
@@ -39,13 +38,6 @@ export default async function (options: { verbose: boolean; ci: boolean }, logge
     error = true;
   }
 
-  if (!options.ci) {
-    logger.info('');
-    logger.info(`Running DO_NOT${''}_SUBMIT validation...`);
-    error = await validateDoNotSubmit({}, logger.createChild('validate-do-not-submit')) != 0
-        || error;
-  }
-
   logger.info('');
   logger.info('Running license validation...');
   error = await validateLicenses({}, logger.createChild('validate-commits')) != 0
