Rename PrimeCache to PrimeCacheAsync (keeping older name as obsolete overload). Fixes aspnet#246.

SteveSandersonMS · SteveSandersonMS · commit 56cb898bdeac · 2016-08-16T13:57:37.000-07:00
diff --git a/samples/angular/MusicStore/Views/Home/Index.cshtml b/samples/angular/MusicStore/Views/Home/Index.cshtml
@@ -4,8 +4,8 @@
 
 <cache vary-by="@Context.Request.Path">
     <app asp-prerender-module="wwwroot/ng-app/boot-server">Loading...</app>
-    @await Html.PrimeCache(Url.Action("GenreMenuList", "GenresApi"))
-    @await Html.PrimeCache(Url.Action("MostPopular", "AlbumsApi"))
+    @await Html.PrimeCacheAsync(Url.Action("GenreMenuList", "GenresApi"))
+    @await Html.PrimeCacheAsync(Url.Action("MostPopular", "AlbumsApi"))
 </cache>
 
 @section scripts {
diff --git a/src/Microsoft.AspNetCore.AngularServices/PrimeCacheHelper.cs b/src/Microsoft.AspNetCore.AngularServices/PrimeCacheHelper.cs
@@ -11,9 +11,15 @@ namespace Microsoft.AspNetCore.AngularServices
 {
     public static class PrimeCacheHelper
     {
-        public static async Task<HtmlString> PrimeCache(this IHtmlHelper html, string url)
+        [Obsolete("Use PrimeCacheAsync instead")]
+        public static Task<IHtmlContent> PrimeCache(this IHtmlHelper html, string url)
         {
-            // TODO: Consider deduplicating the PrimeCache calls (that is, if there are multiple requests to precache
+            return PrimeCacheAsync(html, url);
+        }
+
+        public static async Task<IHtmlContent> PrimeCacheAsync(this IHtmlHelper html, string url)
+        {
+            // TODO: Consider deduplicating the PrimeCacheAsync calls (that is, if there are multiple requests to precache
             // the same URL, only return nonempty for one of them). This will make it easier to auto-prime-cache any
             // HTTP requests made during server-side rendering, without risking unnecessary duplicate requests.
 

Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,15 @@ namespace Microsoft.AspNetCore.AngularServices`
`11`	`11`	`{`
`12`	`12`	`public static class PrimeCacheHelper`
`13`	`13`	`{`
`14`		`- public static async Task<HtmlString> PrimeCache(this IHtmlHelper html, string url)`
	`14`	`+ [Obsolete("Use PrimeCacheAsync instead")]`
	`15`	`+ public static Task<IHtmlContent> PrimeCache(this IHtmlHelper html, string url)`
`15`	`16`	`{`
`16`		`- // TODO: Consider deduplicating the PrimeCache calls (that is, if there are multiple requests to precache`
	`17`	`+ return PrimeCacheAsync(html, url);`
	`18`	`+ }`
	`19`	`+`
	`20`	`+ public static async Task<IHtmlContent> PrimeCacheAsync(this IHtmlHelper html, string url)`
	`21`	`+ {`
	`22`	`+ // TODO: Consider deduplicating the PrimeCacheAsync calls (that is, if there are multiple requests to precache`
`17`	`23`	`// the same URL, only return nonempty for one of them). This will make it easier to auto-prime-cache any`
`18`	`24`	`// HTTP requests made during server-side rendering, without risking unnecessary duplicate requests.`
`19`	`25`