Add test case for PythonSquidSensor

vilchikelena · vilchikelena · commit cfbfca83eabe · 2015-03-11T13:48:42.000+01:00
diff --git a/sonar-python-plugin/src/main/java/org/sonar/plugins/python/PythonSquidSensor.java b/sonar-python-plugin/src/main/java/org/sonar/plugins/python/PythonSquidSensor.java
@@ -142,19 +142,17 @@ private void saveFilesComplexityDistribution(InputFile sonarFile, SourceFile squ
 
   private void saveIssues(InputFile sonarFile, SourceFile squidFile) {
     Collection<CheckMessage> messages = squidFile.getCheckMessages();
-    if (messages != null) {
-      for (CheckMessage message : messages) {
-        RuleKey ruleKey = checks.ruleKey((SquidAstVisitor<Grammar>) message.getCheck());
-        Issuable issuable = resourcePerspectives.as(Issuable.class, sonarFile);
+    for (CheckMessage message : messages) {
+      RuleKey ruleKey = checks.ruleKey((SquidAstVisitor<Grammar>) message.getCheck());
+      Issuable issuable = resourcePerspectives.as(Issuable.class, sonarFile);
 
-        if (issuable != null) {
-          Issue issue = issuable.newIssueBuilder()
+      if (issuable != null) {
+        Issue issue = issuable.newIssueBuilder()
             .ruleKey(ruleKey)
             .line(message.getLine())
             .message(message.getText(Locale.ENGLISH))
             .build();
-          issuable.addIssue(issue);
-        }
+        issuable.addIssue(issue);
       }
     }
   }
diff --git a/sonar-python-plugin/src/test/java/org/sonar/plugins/python/PythonSquidSensorTest.java b/sonar-python-plugin/src/test/java/org/sonar/plugins/python/PythonSquidSensorTest.java
@@ -30,10 +30,14 @@
 import org.sonar.api.batch.rule.CheckFactory;
 import org.sonar.api.batch.rule.internal.ActiveRulesBuilder;
 import org.sonar.api.component.ResourcePerspectives;
+import org.sonar.api.issue.Issuable;
+import org.sonar.api.issue.Issue;
 import org.sonar.api.measures.CoreMetrics;
 import org.sonar.api.measures.FileLinesContext;
 import org.sonar.api.measures.FileLinesContextFactory;
 import org.sonar.api.resources.Project;
+import org.sonar.api.rule.RuleKey;
+import org.sonar.python.checks.CheckList;
 
 import java.io.File;
 
@@ -47,16 +51,21 @@ public class PythonSquidSensorTest {
 
   private PythonSquidSensor sensor;
   private DefaultFileSystem fs = new DefaultFileSystem();
+  ResourcePerspectives perspectives;
 
   @Before
   public void setUp() {
     FileLinesContextFactory fileLinesContextFactory = mock(FileLinesContextFactory.class);
     FileLinesContext fileLinesContext = mock(FileLinesContext.class);
     when(fileLinesContextFactory.createFor(Mockito.any(InputFile.class))).thenReturn(fileLinesContext);
     ActiveRules activeRules = (new ActiveRulesBuilder())
+        .create(RuleKey.of(CheckList.REPOSITORY_KEY, "PrintStatementUsage"))
+        .setName("Print Statement Usage")
+        .activate()
         .build();
     CheckFactory checkFactory = new CheckFactory(activeRules);
-    sensor = new PythonSquidSensor(fileLinesContextFactory, fs, mock(ResourcePerspectives.class), checkFactory);
+    perspectives = mock(ResourcePerspectives.class);
+    sensor = new PythonSquidSensor(fileLinesContextFactory, fs, perspectives, checkFactory);
   }
 
   @Test
@@ -75,6 +84,14 @@ public void should_analyse() {
     inputFile.setAbsolutePath((new File(relativePath)).getAbsolutePath());
     fs.add(inputFile);
 
+    Issuable issuable = mock(Issuable.class);
+    Issuable.IssueBuilder issueBuilder = mock(Issuable.IssueBuilder.class);
+    when(perspectives.as(Mockito.eq(Issuable.class), Mockito.any(InputFile.class))).thenReturn(issuable);
+    when(issuable.newIssueBuilder()).thenReturn(issueBuilder);
+    when(issueBuilder.ruleKey(Mockito.any(RuleKey.class))).thenReturn(issueBuilder);
+    when(issueBuilder.line(Mockito.any(Integer.class))).thenReturn(issueBuilder);
+    when(issueBuilder.message(Mockito.any(String.class))).thenReturn(issueBuilder);
+
     Project project = new Project("key");
     SensorContext context = mock(SensorContext.class);
     sensor.analyse(project, context);
@@ -87,6 +104,8 @@ public void should_analyse() {
     verify(context).saveMeasure(Mockito.any(InputFile.class), Mockito.eq(CoreMetrics.CLASSES), Mockito.eq(1.0));
     verify(context).saveMeasure(Mockito.any(InputFile.class), Mockito.eq(CoreMetrics.COMPLEXITY), Mockito.eq(4.0));
     verify(context).saveMeasure(Mockito.any(InputFile.class), Mockito.eq(CoreMetrics.COMMENT_LINES), Mockito.eq(9.0));
+    verify(issuable).addIssue(Mockito.any(Issue.class));
+
   }
 
 }
