Remove references to the helpDialog, which hasn't existed for at least 11 years.

joedolson · joedolson · commit c7c6d7fe9a2f · 2025-12-30T21:16:49.000-06:00
diff --git a/scripts/buildplayer.js b/scripts/buildplayer.js
@@ -1561,8 +1561,6 @@
 			return this.translate( 'slower', 'Slower' );
 		} else if (control === 'preferences') {
 			return this.translate( 'preferences', 'Preferences' );
-		} else if (control === 'help') {
-			// return this.translate( 'help', 'Help' );
 		} else if (control === 'fullscreen') {
 			return ( !this.fullscreen ) ? this.translate( 'enterFullScreen', 'Enter full screen' ) : this.translate( 'exitFullScreen', 'Exit full screen' );
 		} else {
diff --git a/scripts/control.js b/scripts/control.js
@@ -1122,11 +1122,6 @@
 		}
 	};
 
-	AblePlayer.prototype.handleHelpClick = function() {
-		this.setFullscreen(false);
-		this.helpDialog.show();
-	};
-
 	AblePlayer.prototype.handleTranscriptToggle = function () {
 		var thisObj = this;
 		var visible = this.$transcriptDiv.is(':visible');
diff --git a/scripts/event.js b/scripts/event.js
@@ -348,9 +348,6 @@
 					this.showingPrefsDialog = false;
 				}
 				break;
-			case 'help':
-				this.handleHelpClick();
-				break;
 			case 'transcript':
 				if ( !this.closingTranscript ) {
 					this.handleTranscriptToggle();
@@ -364,10 +361,8 @@
 	};
 
 	AblePlayer.prototype.getButtonNameFromClass = function (classString) {
-
 		// player control buttons all have class="able-button-handler-x"  where x is the identifier
 		// buttons might also have other classes assigned though
-
 		var classes, i;
 
 		classes = classString.split(' ');
@@ -393,11 +388,11 @@
 		// handle keystrokes (using DHTML Style Guide recommended key combinations)
 		// https://web.archive.org/web/20130127004544/http://dev.aol.com/dhtml_style_guide/#mediaplayer
 		// Modifier keys Alt + Ctrl are on by default, but can be changed within Preferences
-		// NOTE #1: Style guide only supports Play/Pause, Stop, Mute, Captions, & Volume Up & Down
+		// - Style guide only supports Play/Pause, Stop, Mute, Captions, & Volume Up & Down
 		// The rest are reasonable best choices
-		// NOTE #2: If there are multiple players on a single page, keystroke handlers
+		// - If there are multiple players on a single page, keystroke handlers
 		// are only bound to the FIRST player
-		// NOTE #3: The DHTML Style Guide is now the W3C WAI-ARIA Authoring Guide and has undergone many revisions
+		// - The DHTML Style Guide is now the W3C WAI-ARIA Authoring Guide and has undergone many revisions
 		// including removal of the "media player" design pattern. There's an issue about that:
 		// https://github.com/w3c/aria-practices/issues/27
 
@@ -837,7 +832,7 @@
 		});
 
 		// handle local keydown events if this isn't the only player on the page;
-		// otherwise these are dispatched by global handler (see ableplayer-base,js)
+		// otherwise these are dispatched by global handler (see ableplayer-base.js)
 		this.$ableDiv.on( 'keydown', function (e) {
 			if (AblePlayer.nextIndex > 1) {
 				thisObj.onPlayerKeyPress(e);
diff --git a/scripts/initialize.js b/scripts/initialize.js
@@ -307,13 +307,6 @@
 				svg[2] = 'icon-fullscreen-collapse';
 				svg[3] = this.fullscreenCollapseButtonImg;
 				break;
-
-			case 'help':
-				svg[0] = '0 0 11 20';
-				svg[1] = 'M0.577 6.317q-0.028-0.167 0.061-0.313 1.786-2.969 5.179-2.969 0.893 0 1.797 0.346t1.629 0.926 1.183 1.423 0.458 1.769q0 0.603-0.173 1.127t-0.391 0.854-0.614 0.664-0.642 0.485-0.681 0.396q-0.458 0.257-0.765 0.725t-0.307 0.748q0 0.19-0.134 0.363t-0.313 0.173h-2.679q-0.167 0-0.285-0.206t-0.117-0.419v-0.502q0-0.926 0.725-1.747t1.596-1.211q0.658-0.301 0.938-0.625t0.279-0.848q0-0.469-0.519-0.826t-1.2-0.357q-0.725 0-1.205 0.324-0.391 0.279-1.194 1.283-0.145 0.179-0.346 0.179-0.134 0-0.279-0.089l-1.83-1.395q-0.145-0.112-0.173-0.279zM3.786 16.875v-2.679q0-0.179 0.134-0.313t0.313-0.134h2.679q0.179 0 0.313 0.134t0.134 0.313v2.679q0 0.179-0.134 0.313t-0.313 0.134h-2.679q-0.179 0-0.313-0.134t-0.134-0.313z';
-				svg[2] = 'icon-help';
-				svg[3] = this.helpButtonImg;
-				break;
 		}
 
 		return svg;
diff --git a/scripts/preference.js b/scripts/preference.js
@@ -681,9 +681,6 @@
 				} else if (this.controls[i] === 'prefs') {
 					kbLabels.push(this.translate( 'preferences', 'Preferences' ));
 					keys.push('e');
-				} else if (this.controls[i] === 'help') {
-					kbLabels.push(this.translate( 'help', 'Help' ));
-					keys.push('h');
 				}
 			}
 			for (i=0; i<keys.length; i++) {

Original file line number	Diff line number	Diff line change
`@@ -681,9 +681,6 @@`
`681`	`681`	`} else if (this.controls[i] === 'prefs') {`
`682`	`682`	`kbLabels.push(this.translate( 'preferences', 'Preferences' ));`
`683`	`683`	`keys.push('e');`
`684`		`- } else if (this.controls[i] === 'help') {`
`685`		`- kbLabels.push(this.translate( 'help', 'Help' ));`
`686`		`- keys.push('h');`
`687`	`684`	`}`
`688`	`685`	`}`
`689`	`686`	`for (i=0; i<keys.length; i++) {`