Skip to content

Commit 1e9898b

Browse files
author
terrill
committed
Fix volume bug in Android
1 parent 75062e8 commit 1e9898b

5 files changed

Lines changed: 12 additions & 6 deletions

File tree

‎build/ableplayer.dist.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1135,7 +1135,9 @@ var AblePlayerInstances = [];
11351135
if (typeof thisObj.volume === 'undefined') {
11361136
thisObj.volume = thisObj.defaultVolume;
11371137
}
1138-
thisObj.setVolume(thisObj.volume);
1138+
if (thisObj.volume) {
1139+
thisObj.setVolume(thisObj.volume);
1140+
}
11391141

11401142
if (thisObj.transcriptType) {
11411143
thisObj.addTranscriptAreaEvents();

‎build/ableplayer.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1135,7 +1135,9 @@ var AblePlayerInstances = [];
11351135
if (typeof thisObj.volume === 'undefined') {
11361136
thisObj.volume = thisObj.defaultVolume;
11371137
}
1138-
thisObj.setVolume(thisObj.volume);
1138+
if (thisObj.volume) {
1139+
thisObj.setVolume(thisObj.volume);
1140+
}
11391141

11401142
if (thisObj.transcriptType) {
11411143
thisObj.addTranscriptAreaEvents();

‎build/ableplayer.min.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ableplayer",
3-
"version": "4.2.13",
3+
"version": "4.2.15",
44
"description": "fully accessible HTML5 media player",
55
"homepage": "http://ableplayer.github.io/ableplayer",
66
"bugs": "https://github.com/ableplayer/ableplayer/issues",

‎scripts/initialize.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,9 @@
581581
if (typeof thisObj.volume === 'undefined') {
582582
thisObj.volume = thisObj.defaultVolume;
583583
}
584-
thisObj.setVolume(thisObj.volume);
584+
if (thisObj.volume) {
585+
thisObj.setVolume(thisObj.volume);
586+
}
585587

586588
if (thisObj.transcriptType) {
587589
thisObj.addTranscriptAreaEvents();

0 commit comments

Comments
 (0)