prefer std::string for setComment()

cdunn2001 · cdunn2001 · commit 50069d72da3c · 2015-04-11T14:49:28.000-05:00
in case of embedded nulls
diff --git a/include/json/value.h b/include/json/value.h
@@ -512,6 +512,7 @@ Json::Value obj_value(Json::objectValue); // {}
   //# endif
 
   /// \deprecated Always pass len.
+  JSONCPP_DEPRECATED("Use setComment(std::string const&) instead.")
   void setComment(const char* comment, CommentPlacement placement);
   /// Comments must be //... or /* ... */
   void setComment(const char* comment, size_t len, CommentPlacement placement);
diff --git a/src/test_lib_json/main.cpp b/src/test_lib_json/main.cpp
@@ -1542,7 +1542,7 @@ JSONTEST_FIXTURE(ValueTest, StaticString) {
 
 JSONTEST_FIXTURE(ValueTest, CommentBefore) {
   Json::Value val; // fill val
-  val.setComment("// this comment should appear before", Json::commentBefore);
+  val.setComment(std::string("// this comment should appear before"), Json::commentBefore);
   Json::StreamWriterBuilder wbuilder;
   wbuilder.settings_["commentStyle"] = "All";
   {

Original file line number	Diff line number	Diff line change
`@@ -1542,7 +1542,7 @@ JSONTEST_FIXTURE(ValueTest, StaticString) {`
`1542`	`1542`
`1543`	`1543`	`JSONTEST_FIXTURE(ValueTest, CommentBefore) {`
`1544`	`1544`	`Json::Value val; // fill val`
`1545`		`- val.setComment("// this comment should appear before", Json::commentBefore);`
	`1545`	`+ val.setComment(std::string("// this comment should appear before"), Json::commentBefore);`
`1546`	`1546`	`Json::StreamWriterBuilder wbuilder;`
`1547`	`1547`	`wbuilder.settings_["commentStyle"] = "All";`
`1548`	`1548`	`{`