Skip to content

Commit ba5c778

Browse files
seanyoungHans Verkuil
seanyoung
authored and
Hans Verkuil
committed
media: rc: remove unused tx_resolution field
The tx_resolution field is never read. In theory you can imagine this field being useful for detecting whether the transmitter has the resolution for the message you are trying to send, but I am not aware of any hardware where this could be an issue. Just remove. Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 512d189 commit ba5c778

4 files changed

Lines changed: 0 additions & 7 deletions

File tree

‎drivers/media/rc/ene_ir.c‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -451,9 +451,6 @@ static void ene_rx_setup(struct ene_device *dev)
451451
dev->rdev->max_timeout = 200000;
452452
}
453453

454-
if (dev->hw_learning_and_tx_capable)
455-
dev->rdev->tx_resolution = sample_period;
456-
457454
if (dev->rdev->timeout > dev->rdev->max_timeout)
458455
dev->rdev->timeout = dev->rdev->max_timeout;
459456
if (dev->rdev->timeout < dev->rdev->min_timeout)

‎drivers/media/rc/ite-cir.c‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1380,7 +1380,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
13801380
rdev->timeout = IR_DEFAULT_TIMEOUT;
13811381
rdev->max_timeout = 10 * IR_DEFAULT_TIMEOUT;
13821382
rdev->rx_resolution = ITE_BAUDRATE_DIVISOR * sample_period / 1000;
1383-
rdev->tx_resolution = ITE_BAUDRATE_DIVISOR * sample_period / 1000;
13841383

13851384
/* set up transmitter related values */
13861385
rdev->tx_ir = ite_tx_ir;

‎drivers/media/rc/rc-loopback.c‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,6 @@ static int __init loop_init(void)
230230
rc->min_timeout = 1;
231231
rc->max_timeout = IR_MAX_TIMEOUT;
232232
rc->rx_resolution = 1;
233-
rc->tx_resolution = 1;
234233
rc->s_tx_mask = loop_set_tx_mask;
235234
rc->s_tx_carrier = loop_set_tx_carrier;
236235
rc->s_tx_duty_cycle = loop_set_tx_duty_cycle;

‎include/media/rc-core.h‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ struct lirc_fh {
127127
* @min_timeout: minimum timeout supported by device
128128
* @max_timeout: maximum timeout supported by device
129129
* @rx_resolution : resolution (in us) of input sampler
130-
* @tx_resolution: resolution (in us) of output sampler
131130
* @lirc_dev: lirc device
132131
* @lirc_cdev: lirc char cdev
133132
* @gap_start: start time for gap after timeout if non-zero
@@ -194,7 +193,6 @@ struct rc_dev {
194193
u32 min_timeout;
195194
u32 max_timeout;
196195
u32 rx_resolution;
197-
u32 tx_resolution;
198196
#ifdef CONFIG_LIRC
199197
struct device lirc_dev;
200198
struct cdev lirc_cdev;

0 commit comments

Comments
 (0)