Merge pull request #3088 from kfeuz/client_memory_leak

benfry · benfry · commit 598613300d39 · 2015-04-01T11:33:36.000-04:00
Prevent memory leak of Client by unregistering parent dispose method
diff --git a/java/libraries/net/src/processing/net/Client.java b/java/libraries/net/src/processing/net/Client.java
@@ -61,6 +61,7 @@ public class Client implements Runnable {
   int bufferIndex;
   int bufferLast;
 
+  boolean isDisposeRegistered = false;
   
   /**
    * @param parent typically use "this"
@@ -81,6 +82,7 @@ public Client(PApplet parent, String host, int port) {
       thread.start();
 
       parent.registerMethod("dispose", this);
+      isDisposeRegistered = true;
 
       // reflection to check whether host sketch has a call for
       // public void clientEvent(processing.net.Client)
@@ -158,6 +160,10 @@ public void stop() {
         disconnectEventMethod = null;
       }
     }
+    if(isDisposeRegistered){
+      parent.unregisterMethod("dispose", this);
+      isDisposeRegistered = false;
+    }
     dispose();
   }
 
