Skip to content

Commit 37752a2

Browse files
committed
remove jdt.compiler.jar as javac engine from subprojects
1 parent d9ae6c9 commit 37752a2

File tree

4 files changed

+17
-21
lines changed

4 files changed

+17
-21
lines changed

build/shared/tools/MovieMaker/build.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -64,17 +64,14 @@
6464

6565
<target name="compile" description="Compile sources">
6666
<mkdir dir="bin" />
67-
<javac target="1.8"
68-
source="1.8"
67+
<javac target="11"
68+
source="11"
6969
srcdir="src"
7070
destdir="bin"
7171
encoding="UTF-8"
7272
includeAntRuntime="false"
7373
classpath="../../../../app/bin"
74-
nowarn="true">
75-
<compilerclasspath path="../../../../java/mode/org.eclipse.jdt.core.jar;
76-
../../../../java/mode/jdtCompilerAdapter.jar" />
77-
</javac>
74+
nowarn="true" />
7875
</target>
7976

8077
<target name="build" depends="compile, prepare-ffmpeg" description="Build Movie Maker Tool">

java/libraries/io/build.xml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,22 @@
66
<delete file="library/io.jar" />
77
</target>
88

9+
<property name="core.path" location="../../../core/library/core.jar" />
10+
911
<target name="compile" description="Compile sources">
1012
<condition property="core-built">
11-
<available file="../../../core/library/core.jar" />
13+
<available file="${core.path}" />
1214
</condition>
13-
<fail unless="core-built" message="Please build the core library first and make sure it sits in ../../../core/library/core.jar" />
15+
<fail unless="core-built" message="Please build the core library first and make sure it is located at ${core.path}" />
1416

1517
<mkdir dir="bin" />
1618
<javac source="11"
17-
target="11"
18-
srcdir="src" destdir="bin"
19-
encoding="UTF-8"
20-
includeAntRuntime="false"
21-
classpath="../../../core/library/core.jar"
22-
nowarn="true"
23-
compiler="org.eclipse.jdt.core.JDTCompilerAdapter">
24-
<compilerclasspath path="../../mode/org.eclipse.jdt.core.jar;
25-
../../mode/jdtCompilerAdapter.jar" />
26-
</javac>
19+
target="11"
20+
srcdir="src" destdir="bin"
21+
encoding="UTF-8"
22+
includeAntRuntime="false"
23+
classpath="${core.path}"
24+
nowarn="true" />
2725
</target>
2826

2927
<target name="build" depends="compile" description="Build I/O library">
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
io.jar

todo.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ X Editor.applyPreferences() was protected, now public
88
X remove compound key actions (which were undocumented and not in use)
99
X clears up a lot of complexity in DefaultInputHandler
1010
X if someone wants this, they could recreate it in a subclass
11+
X remove jdt.compiler.jar from subprojects
12+
X no longer using JRE (doesn't exist), so it's not needed
13+
o can we remove it altogether, or is it used by the PDE?
1114

1215
readme
1316
X was fixed in the source for 4.0a5, but may not have been included in the dist
@@ -62,9 +65,6 @@ _ move ISSUE_TEMPLATE to .github subfolder
6265
_ lots more cleanup to do in javafx/build.xml
6366
_ only export 'tool' subfolder for Movie Maker (and Theme Engine?)
6467

65-
_ remove jdt.compiler.jar from subprojects
66-
_ no longer using JRE (doesn't exist), so it's not needed
67-
_ can we remove it altogether, or is it used by the PDE?
6868

6969
_ startup is so incredibly slow
7070
_ the splash screen comes up fairly quickly, so what gives?

0 commit comments

Comments
 (0)