Skip to content

Commit 19d436b

Browse files
committed
additional cleanups and bug fixes
1 parent f23d723 commit 19d436b

File tree

1 file changed

+15
-4
lines changed

1 file changed

+15
-4
lines changed

java/src/processing/mode/java/tweak/ColorSelector.java

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import java.awt.Dimension;
2727
import java.awt.Graphics;
2828
import java.awt.Graphics2D;
29+
import java.awt.RenderingHints;
2930
import java.awt.event.MouseAdapter;
3031
import java.awt.event.MouseEvent;
3132
import java.awt.geom.AffineTransform;
@@ -144,7 +145,8 @@ class ColorSelectorBox extends JComponent {
144145
public void mousePressed(MouseEvent e) {
145146
updateMouse(e);
146147
}
147-
148+
});
149+
addMouseMotionListener(new MouseAdapter() {
148150
public void mouseDragged(MouseEvent e) {
149151
updateMouse(e);
150152
}
@@ -156,10 +158,16 @@ public void paintComponent(Graphics g) {
156158
g.drawImage(backImg, 0, 0, this);
157159

158160
Graphics2D g2 = (Graphics2D) g;
161+
// otherwise the oval is hideous
162+
// TODO make a proper hidpi version of all this
163+
g2.setRenderingHint(RenderingHints.KEY_ANTIALIASING,
164+
RenderingHints.VALUE_ANTIALIAS_ON);
165+
159166
g.setColor(lastY < 128 ? Color.BLACK : Color.WHITE);
160167
AffineTransform tx = g2.getTransform();
161168
g2.translate(lastX, lastY);
162-
g2.drawOval(0, 0, 5, 5);
169+
//g2.drawOval(0, 0, 5, 5);
170+
g2.drawOval(-3, -3, 6, 6);
163171
g2.drawLine(-8, 0, -6, 0);
164172
g2.drawLine(6, 0, 8, 0);
165173
g2.drawLine(0, -8, 0, -6);
@@ -174,7 +182,7 @@ public void renderBack() {
174182
for (int j = 0; j < 256; j++) {
175183
for (int i = 0; i < 256; i++) {
176184
pixels[index++] = // color(hue, i, 255-j);
177-
Color.HSBtoRGB(hue / 255f, (i / 255f), (255-j));
185+
Color.HSBtoRGB(hue / 255f, (i / 255f), (255-j)/255f);
178186
}
179187
}
180188
backImg = new BufferedImage(256, 256, BufferedImage.TYPE_INT_RGB);
@@ -256,7 +264,8 @@ class ColorSelectorSlider extends JComponent {
256264
public void mousePressed(MouseEvent e) {
257265
updateMouse(e);
258266
}
259-
267+
});
268+
addMouseMotionListener(new MouseAdapter() {
260269
public void mouseDragged(MouseEvent e) {
261270
updateMouse(e);
262271
}
@@ -304,6 +313,7 @@ public void paintComponent(Graphics g) {
304313
g.drawRect(24, -2, 4, 4);
305314
g2.setTransform(tx);
306315

316+
/*
307317
if (colorBox.isBW) {
308318
// stroke(255);
309319
// rect(0, 0, 29, 254);
@@ -317,6 +327,7 @@ public void paintComponent(Graphics g) {
317327
g.drawLine(0, 0, 0, 255);
318328
g.drawLine(29, 0, 29, 255);
319329
}
330+
*/
320331
}
321332

322333

0 commit comments

Comments
 (0)