Improve styling & clarity for fix.

Hainish · Hainish · commit abb63ac3ba91 · 2016-02-05T14:14:11.000-08:00
diff --git a/src/chrome/content/code/ApplicableList.js b/src/chrome/content/code/ApplicableList.js
@@ -214,12 +214,14 @@ ApplicableList.prototype = {
 
   add_command: function(rule) {
       // basic validation for data to be added to xul
-      if(!String(rule.id).match(/^[a-zA-Z_0-9]+$/))
+      var ruleId = String(rule.id);
+      if (!ruleId.match(/^[a-zA-Z_0-9]+$/)) {
         return;
+      }
 
       var command = this.document.getElementById("https-everywhere-menuitem-rule-toggle-template").cloneNode();
-      command.setAttribute('id', rule.id+'-command');
-      command.setAttribute('data-id', rule.id);
+      command.setAttribute('id', ruleId+'-command');
+      command.setAttribute('data-id', ruleId);
       command.setAttribute('label', rule.name);
       this.commandset.appendChild(command);
   },
