Skip to content

Commit 59304d9

Browse files
committed
Merge branch 'un-unpack' of https://github.com/chrmod/https-everywhere into chrmod-un-unpack
Conflicts: src/install.rdf
2 parents 2c2b083 + 6e1ec35 commit 59304d9

File tree

3 files changed

+30
-8
lines changed

3 files changed

+30
-8
lines changed

src/chrome/content/code/HTTPSRules.js

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,30 @@ const RuleWriter = {
246246
return rv;
247247
},
248248

249-
read: function(file) {
249+
readFromUrl: function (url) {
250+
var ios = CC['@mozilla.org/network/io-service;1']
251+
.getService(CI.nsIIOService);
252+
var encoding = "UTF-8";
253+
var channel = ios.newChannel(url, encoding, null);
254+
var stream = channel.open();
255+
var streamSize = stream.available();
256+
257+
if (!streamSize) {
258+
return null;
259+
}
260+
261+
var convStream = CC["@mozilla.org/intl/converter-input-stream;1"]
262+
.createInstance(CI.nsIConverterInputStream);
263+
264+
convStream.init(stream, encoding, streamSize,
265+
convStream.DEFAULT_REPLACEMENT_CHARACTER);
266+
267+
var data = {};
268+
convStream.readString(streamSize, data);
269+
270+
return data.value;
271+
},
272+
readFromFile: function(file) {
250273
if (!file.exists())
251274
return null;
252275
var data = "";
@@ -285,7 +308,7 @@ const RuleWriter = {
285308
rulesetFromFile: function(file, rule_store, ruleset_id) {
286309
if ((rule_store.targets == null) && (rule_store.targets != {}))
287310
this.log(WARN, "TARGETS IS NULL");
288-
var data = this.read(file);
311+
var data = this.readFromFile(file);
289312
if (!data) return null;
290313
return this.readFromString(data, rule_store, ruleset_id);
291314
},
@@ -409,8 +432,9 @@ const HTTPSRules = {
409432
* XML string, which will be parsed on an as-needed basis.
410433
*/
411434
loadTargets: function() {
412-
var file = new FileUtils.File(RuleWriter.chromeToPath("chrome://https-everywhere/content/rulesets.json"));
413-
var rules = JSON.parse(RuleWriter.read(file));
435+
var loc = "chrome://https-everywhere/content/rulesets.json";
436+
var data = RuleWriter.readFromUrl(loc);
437+
var rules = JSON.parse(data);
414438
this.targets = rules.targets;
415439
this.rulesetStrings = rules.rulesetStrings;
416440
},

src/components/https-everywhere.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -468,9 +468,7 @@ HTTPSEverywhere.prototype = {
468468
loadOCSPList: function() {
469469
try {
470470
var loc = "chrome://https-everywhere/content/code/commonOCSP.json";
471-
var file = CC["@mozilla.org/file/local;1"].createInstance(CI.nsILocalFile);
472-
file.initWithPath(this.rw.chromeToPath(loc));
473-
var data = this.rw.read(file);
471+
var data = this.rw.readFromUrl(loc);
474472
this.ocspList = JSON.parse(data);
475473
} catch(e) {
476474
this.log(WARN, "Failed to load OCSP list: " + e);

src/install.rdf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<em:homepageURL>https://www.eff.org/https-everywhere</em:homepageURL>
1515
<em:optionsURL>chrome://https-everywhere/content/observatory-preferences.xul</em:optionsURL>
1616
<em:iconURL>chrome://https-everywhere/skin/icon-active-48.png</em:iconURL>
17-
<em:unpack>true</em:unpack> <!-- Required for Firefox 4 -->
17+
<em:unpack>false</em:unpack>
1818
<em:updateURL>https://www.eff.org/files/https-everywhere-eff-update-2048.rdf</em:updateURL> <!-- 2015-08-14: New update URL to go with new id (https-everywhere-eff@ef.org) -->
1919
<em:updateKey>MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA6MR8W/galdxnpGqBsYbqOzQb2eyW15YFjDDEMI0ZOzt8f504obNs920lDnpPD2/KqgsfjOgw2K7xWDJIj/18xUvWPk3LDkrnokNiRkA3KOx3W6fHycKL+zID7zy+xZYBuh2fLyQtWV1VGQ45iNRp9+Zo7rH86cdfgkdnWTlNSHyTLW9NbXvyv/E12bppPcEvgCTAQXgnDVJ0/sqmeiijn9tTFh03aM+R2V/21h8aTraAS24qiPCz6gkmYGC8yr6mglcnNoYbsLNYZ69zF1XHcXPduCPdPdfLlzVlKK1/U7hkA28eG3BIAMh6uJYBRJTpiGgaGdPd7YekUB8S6cy+CQIDAQAB</em:updateKey>
2020
<!-- Firefox -->

0 commit comments

Comments
 (0)