no-throw-literal

a-tarasyuk · a-tarasyuk · commit 12e195c24e2a · 2019-06-14T10:54:11.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -103,7 +103,7 @@
         "no-shadow": "off",
         "no-sparse-arrays": "error",
         "no-template-curly-in-string": "off",
-        "no-throw-literal": "off",
+        "no-throw-literal": "error",
         "no-trailing-spaces": "off",
         "no-undef-init": "error",
         "no-unsafe-finally": "error",
diff --git a/scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.ts b/scripts/importDefinitelyTypedTests/importDefinitelyTypedTests.ts
@@ -18,7 +18,7 @@ function main() {
     const [, progName, tscRoot, definitelyTypedRoot] = process.argv;
     if (process.argv.length !== 4) {
         if (process.argv.length < 2) {
-            throw "Expected at least 2 argv elements.";
+            throw new Error("Expected at least 2 argv elements.");
         }
         console.log("Usage:");
         console.log(`    node ${path.relative(__dirname, progName)} [TypeScript Repo Root] [DefinitelyTyped Repo Root]`);

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ function main() {`
`18`	`18`	`const [, progName, tscRoot, definitelyTypedRoot] = process.argv;`
`19`	`19`	`if (process.argv.length !== 4) {`
`20`	`20`	`if (process.argv.length < 2) {`
`21`		`- throw "Expected at least 2 argv elements.";`
	`21`	`+ throw new Error("Expected at least 2 argv elements.");`
`22`	`22`	`}`
`23`	`23`	`console.log("Usage:");`
`24`	`24`	console.log(` node ${path.relative(__dirname, progName)} [TypeScript Repo Root] [DefinitelyTyped Repo Root]`);