fix deal with repositoryName with SHA256

张宇鹏（执风） · 张宇鹏（执风） · commit 63932f45f99d · 2018-01-05T21:19:47.000+08:00
diff --git a/src/main/java/com/github/dockerjava/core/NameParser.java b/src/main/java/com/github/dockerjava/core/NameParser.java
@@ -5,6 +5,7 @@
 
 import java.util.regex.Pattern;
 
+import org.apache.commons.lang.StringUtils;
 import org.apache.commons.lang.builder.EqualsBuilder;
 import org.apache.commons.lang.builder.ToStringBuilder;
 import org.apache.commons.lang.builder.ToStringStyle;
@@ -20,6 +21,8 @@ private NameParser() {
     // CHECKSTYLE:OFF
     private static final int RepositoryNameTotalLengthMax = 255;
 
+    private static final String SHA256_SEPARATOR = "@sha256:";
+
     private static final Pattern RepositoryNameComponentRegexp = Pattern.compile("[a-z0-9]+(?:[._-][a-z0-9]+)*");
 
     private static final Pattern RepositoryNameComponentAnchoredRegexp = Pattern.compile("^"
@@ -37,6 +40,9 @@ public static ReposTag parseRepositoryTag(String name) {
             return new ReposTag(name, "");
         }
         String tag = name.substring(n + 1);
+        if (StringUtils.containsIgnoreCase(name, SHA256_SEPARATOR)) {
+            return new ReposTag(name, "");
+        }
         if (!tag.contains("/")) {
             return new ReposTag(name.substring(0, n), tag);
         }
@@ -110,6 +116,9 @@ public static HostnameReposName resolveRepositoryName(String reposName) {
             throw new InvalidRepositoryNameException(String.format("Invalid repository name, try \"%s\" instead",
                     reposName));
         }
+        if (StringUtils.containsIgnoreCase(reposName, SHA256_SEPARATOR)) {
+            reposName = StringUtils.substringBeforeLast(reposName, SHA256_SEPARATOR);
+        }
 
         validateRepoName(reposName);
         return new HostnameReposName(hostname, reposName);
diff --git a/src/test/java/com/github/dockerjava/core/NameParserTest.java b/src/test/java/com/github/dockerjava/core/NameParserTest.java
@@ -89,12 +89,24 @@ public void testResolveRepositoryNameWithNamespace() throws Exception {
         assertEquals(resolved, new HostnameReposName(AuthConfig.DEFAULT_SERVER_ADDRESS, "namespace/repository"));
     }
 
+    @Test
+    public void testResolveRepositoryNameWithNamespaceAndSHA256() throws Exception {
+        HostnameReposName resolved = NameParser.resolveRepositoryName("namespace/repository@sha256:sha256");
+        assertEquals(resolved, new HostnameReposName(AuthConfig.DEFAULT_SERVER_ADDRESS, "namespace/repository@sha256:sha256"));
+    }
+
     @Test
     public void testResolveRepositoryNameWithNamespaceAndHostname() throws Exception {
         HostnameReposName resolved = NameParser.resolveRepositoryName("localhost:5000/namespace/repository");
         assertEquals(resolved, new HostnameReposName("localhost:5000", "namespace/repository"));
     }
 
+    @Test
+    public void testResolveRepositoryNameWithNamespaceAndHostnameAndSHA256() throws Exception {
+        HostnameReposName resolved = NameParser.resolveRepositoryName("localhost:5000/namespace/repository@sha256:sha256");
+        assertEquals(resolved, new HostnameReposName("localhost:5000", "namespace/repository"));
+    }
+
     @Test(expected = InvalidRepositoryNameException.class)
     public void testResolveRepositoryNameWithIndex() throws Exception {
         NameParser.resolveRepositoryName("index.docker.io/repository");
@@ -123,4 +135,16 @@ public void testResolveReposTagWithTag() throws Exception {
         resolved = NameParser.parseRepositoryTag("localhost:5000/namespace/repository:tag");
         assertEquals(resolved, new ReposTag("localhost:5000/namespace/repository", "tag"));
     }
+
+    @Test
+    public void testResolveReposTagWithSHA256() throws Exception {
+        ReposTag resolved = NameParser.parseRepositoryTag("repository@sha256:sha256");
+        assertEquals(resolved, new ReposTag("repository@sha256:sha256", ""));
+
+        resolved = NameParser.parseRepositoryTag("namespace/repository@sha256:sha256");
+        assertEquals(resolved, new ReposTag("namespace/repository@sha256:sha256", ""));
+
+        resolved = NameParser.parseRepositoryTag("localhost:5000/namespace/repository@sha256:sha256");
+        assertEquals(resolved, new ReposTag("localhost:5000/namespace/repository@sha256:sha256", ""));
+    }
 }
