image: Add support for additional image import methods

stephenfin · stephenfin · commit 6dea276e5a42 · 2022-11-30T17:15:29.000Z
These are now supported in openstacksdk so we can use them. Change-Id: Ie3107ba2155f9008e6065171298f85978957a172 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Depends-on: https://review.opendev.org/c/openstack/openstacksdk/+/864029
diff --git a/openstackclient/image/v2/image.py b/openstackclient/image/v2/image.py
@@ -1793,10 +1793,10 @@ def take_action(self, parsed_args):
         image_client.import_image(
             image,
             method=parsed_args.import_method,
-            # uri=parsed_args.uri,
-            # remote_region=parsed_args.remote_region,
-            # remote_image=parsed_args.remote_image,
-            # remote_service_interface=parsed_args.remote_service_interface,
+            uri=parsed_args.uri,
+            remote_region=parsed_args.remote_region,
+            remote_image=parsed_args.remote_image,
+            remote_service_interface=parsed_args.remote_service_interface,
             stores=parsed_args.stores,
             all_stores=parsed_args.all_stores,
             all_stores_must_succeed=not parsed_args.allow_failure,
diff --git a/openstackclient/tests/unit/image/v2/test_image.py b/openstackclient/tests/unit/image/v2/test_image.py
@@ -1856,6 +1856,10 @@ def test_import_image__glance_direct(self):
         self.client.import_image.assert_called_once_with(
             self.image,
             method='glance-direct',
+            uri=None,
+            remote_region=None,
+            remote_image=None,
+            remote_service_interface=None,
             stores=None,
             all_stores=None,
             all_stores_must_succeed=False,
@@ -1880,7 +1884,10 @@ def test_import_image__web_download(self):
         self.client.import_image.assert_called_once_with(
             self.image,
             method='web-download',
-            # uri='https://example.com/',
+            uri='https://example.com/',
+            remote_region=None,
+            remote_image=None,
+            remote_service_interface=None,
             stores=None,
             all_stores=None,
             all_stores_must_succeed=False,
@@ -1978,6 +1985,10 @@ def test_import_image__copy_image(self):
         self.client.import_image.assert_called_once_with(
             self.image,
             method='copy-image',
+            uri=None,
+            remote_region=None,
+            remote_image=None,
+            remote_service_interface=None,
             stores=['fast'],
             all_stores=None,
             all_stores_must_succeed=False,
@@ -2005,9 +2016,10 @@ def test_import_image__glance_download(self):
         self.client.import_image.assert_called_once_with(
             self.image,
             method='glance-download',
-            # remote_region='eu/dublin',
-            # remote_image='remote-image-id',
-            # remote_service_interface='private',
+            uri=None,
+            remote_region='eu/dublin',
+            remote_image='remote-image-id',
+            remote_service_interface='private',
             stores=None,
             all_stores=None,
             all_stores_must_succeed=False,
