fix(ios): resilience to nativeView access under edge cases (NativeScript#10276)

NathanWalker · web-flow · commit 4551da075b07 · 2023-04-24T13:45:31.000-07:00
diff --git a/packages/core/ui/core/view/index.ios.ts b/packages/core/ui/core/view/index.ios.ts
@@ -898,13 +898,15 @@ export class View extends ViewCommon implements ViewDefinition {
 			CATransaction.begin();
 		}
 
-		if (value instanceof UIColor) {
-			this.nativeViewProtected.backgroundColor = value;
-		} else {
-			iosBackground.createBackgroundUIColor(this, (color: UIColor) => {
-				this.nativeViewProtected.backgroundColor = color;
-			});
-			this._setNativeClipToBounds();
+		if (this.nativeViewProtected) {
+			if (value instanceof UIColor) {
+				this.nativeViewProtected.backgroundColor = value;
+			} else {
+				iosBackground.createBackgroundUIColor(this, (color: UIColor) => {
+					this.nativeViewProtected.backgroundColor = color;
+				});
+				this._setNativeClipToBounds();
+			}
 		}
 
 		if (!updateSuspended) {
@@ -915,8 +917,10 @@ export class View extends ViewCommon implements ViewDefinition {
 	}
 
 	_setNativeClipToBounds() {
-		const backgroundInternal = this.style.backgroundInternal;
-		this.nativeViewProtected.clipsToBounds = (this.nativeViewProtected instanceof UIScrollView || backgroundInternal.hasBorderWidth() || backgroundInternal.hasBorderRadius()) && !backgroundInternal.hasBoxShadow();
+		if (this.nativeViewProtected) {
+			const backgroundInternal = this.style.backgroundInternal;
+			this.nativeViewProtected.clipsToBounds = (this.nativeViewProtected instanceof UIScrollView || backgroundInternal.hasBorderWidth() || backgroundInternal.hasBorderRadius()) && !backgroundInternal.hasBoxShadow();
+		}
 	}
 
 	private _setupPopoverControllerDelegate(controller: UIViewController, parent: View) {
diff --git a/packages/core/ui/layouts/layout-base.ios.ts b/packages/core/ui/layouts/layout-base.ios.ts
@@ -23,7 +23,9 @@ export class LayoutBase extends LayoutBaseCommon {
 
 	_setNativeClipToBounds() {
 		if (this.clipToBounds) {
-			this.nativeViewProtected.clipsToBounds = true;
+			if (this.nativeViewProtected) {
+				this.nativeViewProtected.clipsToBounds = true;
+			}
 		} else {
 			super._setNativeClipToBounds();
 		}
diff --git a/packages/core/ui/list-view/index.ios.ts b/packages/core/ui/list-view/index.ios.ts
@@ -275,7 +275,9 @@ export class ListView extends ListViewBase {
 
 	_setNativeClipToBounds() {
 		// Always set clipsToBounds for list-view
-		this.ios.clipsToBounds = true;
+		if (this.ios) {
+			this.ios.clipsToBounds = true;
+		}
 	}
 
 	@profile

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,9 @@ export class ListView extends ListViewBase {`
`275`	`275`
`276`	`276`	`_setNativeClipToBounds() {`
`277`	`277`	`// Always set clipsToBounds for list-view`
`278`		`- this.ios.clipsToBounds = true;`
	`278`	`+ if (this.ios) {`
	`279`	`+ this.ios.clipsToBounds = true;`
	`280`	`+ }`
`279`	`281`	`}`
`280`	`282`
`281`	`283`	`@profile`