Skip to content

Commit 22c79df

Browse files
IgorMinarIgorMinar
committed
build(gulp): remove gulp-jasmine, run tests in a new process instead
otherwise we see occasional failures due to require.cache and other global state collisions
1 parent a527985 commit 22c79df

4 files changed

Lines changed: 12 additions & 488 deletions

File tree

‎gulpfile.js‎

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ gulp.task('serve/benchmarks_external.dart', pubserve(gulp, gulpPlugins, {
362362
// doc generation
363363
var Dgeni = require('dgeni');
364364
var bower = require('bower');
365-
var jasmine = require('gulp-jasmine');
366365
var webserver = require('gulp-webserver');
367366

368367
gulp.task('docs/bower', function() {
@@ -408,11 +407,12 @@ function createDocsTasks(publicBuild) {
408407
return gulp.watch('docs/app/**/*', [taskPrefix + '/app']);
409408
});
410409

411-
gulp.task(taskPrefix + '/test', function () {
412-
return gulp.src('docs/**/*.spec.js')
413-
.pipe(jasmine({
414-
includeStackTrace: true
415-
}));
410+
gulp.task(taskPrefix + '/test', function (done) {
411+
fork('./tools/traceur-jasmine', ['docs/**/*.spec.js'], {
412+
stdio: 'inherit'
413+
}).on('close', function (exitCode) {
414+
done(exitCode);
415+
});
416416
});
417417

418418
gulp.task(taskPrefix + '/serve', function() {
@@ -501,11 +501,12 @@ gulp.task('test.server.dart', runServerDartTests(gulp, gulpPlugins, {
501501

502502
// -----------------
503503
// test builders
504-
gulp.task('test.transpiler.unittest', function() {
505-
return gulp.src('tools/transpiler/unittest/**/*.js')
506-
.pipe(jasmine({
507-
includeStackTrace: true
508-
}));
504+
gulp.task('test.transpiler.unittest', function(done) {
505+
fork('./tools/traceur-jasmine', ['tools/transpiler/unittest/**/*.js'], {
506+
stdio: 'inherit'
507+
}).on('close', function (exitCode) {
508+
done(exitCode);
509+
});
509510
});
510511

511512
// -----------------

‎npm-shrinkwrap.clean.json‎

Lines changed: 0 additions & 187 deletions
Original file line numberDiff line numberDiff line change
@@ -4607,193 +4607,6 @@
46074607
}
46084608
}
46094609
},
4610-
"gulp-jasmine": {
4611-
"version": "1.0.1",
4612-
"dependencies": {
4613-
"gulp-util": {
4614-
"version": "3.0.4",
4615-
"dependencies": {
4616-
"array-differ": {
4617-
"version": "1.0.0"
4618-
},
4619-
"array-uniq": {
4620-
"version": "1.0.2"
4621-
},
4622-
"beeper": {
4623-
"version": "1.0.0"
4624-
},
4625-
"chalk": {
4626-
"version": "1.0.0",
4627-
"dependencies": {
4628-
"ansi-styles": {
4629-
"version": "2.0.1"
4630-
},
4631-
"escape-string-regexp": {
4632-
"version": "1.0.3"
4633-
},
4634-
"has-ansi": {
4635-
"version": "1.0.3",
4636-
"dependencies": {
4637-
"ansi-regex": {
4638-
"version": "1.1.1"
4639-
},
4640-
"get-stdin": {
4641-
"version": "4.0.1"
4642-
}
4643-
}
4644-
},
4645-
"strip-ansi": {
4646-
"version": "2.0.1",
4647-
"dependencies": {
4648-
"ansi-regex": {
4649-
"version": "1.1.1"
4650-
}
4651-
}
4652-
},
4653-
"supports-color": {
4654-
"version": "1.3.1"
4655-
}
4656-
}
4657-
},
4658-
"dateformat": {
4659-
"version": "1.0.11",
4660-
"dependencies": {
4661-
"get-stdin": {
4662-
"version": "4.0.1"
4663-
},
4664-
"meow": {
4665-
"version": "3.1.0",
4666-
"dependencies": {
4667-
"camelcase-keys": {
4668-
"version": "1.0.0",
4669-
"dependencies": {
4670-
"camelcase": {
4671-
"version": "1.0.2"
4672-
},
4673-
"map-obj": {
4674-
"version": "1.0.0"
4675-
}
4676-
}
4677-
},
4678-
"indent-string": {
4679-
"version": "1.2.1",
4680-
"dependencies": {
4681-
"repeating": {
4682-
"version": "1.1.2",
4683-
"dependencies": {
4684-
"is-finite": {
4685-
"version": "1.0.0"
4686-
}
4687-
}
4688-
}
4689-
}
4690-
}
4691-
}
4692-
}
4693-
}
4694-
},
4695-
"lodash._reescape": {
4696-
"version": "3.0.0"
4697-
},
4698-
"lodash._reevaluate": {
4699-
"version": "3.0.0"
4700-
},
4701-
"lodash._reinterpolate": {
4702-
"version": "3.0.0"
4703-
},
4704-
"lodash.template": {
4705-
"version": "3.4.0",
4706-
"dependencies": {
4707-
"lodash._basecopy": {
4708-
"version": "3.0.0"
4709-
},
4710-
"lodash._basetostring": {
4711-
"version": "3.0.0"
4712-
},
4713-
"lodash._basevalues": {
4714-
"version": "3.0.0"
4715-
},
4716-
"lodash._isiterateecall": {
4717-
"version": "3.0.5"
4718-
},
4719-
"lodash.escape": {
4720-
"version": "3.0.0"
4721-
},
4722-
"lodash.keys": {
4723-
"version": "3.0.5",
4724-
"dependencies": {
4725-
"lodash.isarguments": {
4726-
"version": "3.0.1"
4727-
},
4728-
"lodash.isarray": {
4729-
"version": "3.0.1"
4730-
},
4731-
"lodash.isnative": {
4732-
"version": "3.0.1"
4733-
}
4734-
}
4735-
},
4736-
"lodash.restparam": {
4737-
"version": "3.6.0"
4738-
},
4739-
"lodash.templatesettings": {
4740-
"version": "3.1.0"
4741-
}
4742-
}
4743-
},
4744-
"multipipe": {
4745-
"version": "0.1.2",
4746-
"dependencies": {
4747-
"duplexer2": {
4748-
"version": "0.0.2",
4749-
"dependencies": {
4750-
"readable-stream": {
4751-
"version": "1.1.13",
4752-
"dependencies": {
4753-
"core-util-is": {
4754-
"version": "1.0.1"
4755-
},
4756-
"isarray": {
4757-
"version": "0.0.1"
4758-
},
4759-
"string_decoder": {
4760-
"version": "0.10.31"
4761-
},
4762-
"inherits": {
4763-
"version": "2.0.1"
4764-
}
4765-
}
4766-
}
4767-
}
4768-
}
4769-
}
4770-
},
4771-
"object-assign": {
4772-
"version": "2.0.0"
4773-
},
4774-
"replace-ext": {
4775-
"version": "0.0.1"
4776-
}
4777-
}
4778-
},
4779-
"require-uncached": {
4780-
"version": "1.0.2",
4781-
"dependencies": {
4782-
"caller-path": {
4783-
"version": "0.1.0",
4784-
"dependencies": {
4785-
"callsites": {
4786-
"version": "0.2.0"
4787-
}
4788-
}
4789-
},
4790-
"resolve-from": {
4791-
"version": "1.0.0"
4792-
}
4793-
}
4794-
}
4795-
}
4796-
},
47974610
"gulp-load-plugins": {
47984611
"version": "0.7.1",
47994612
"dependencies": {

0 commit comments

Comments
 (0)