Add support for global namespace in NS builder

nikic · nikic · commit f9fc2fc9ee3b · 2015-03-10T15:28:19.000+01:00
NULL argument can now be used to create a global namespace {} block.
diff --git a/lib/PhpParser/Builder/Namespace_.php b/lib/PhpParser/Builder/Namespace_.php
@@ -14,10 +14,10 @@ class Namespace_ extends PhpParser\BuilderAbstract
     /**
      * Creates a namespace builder.
      *
-     * @param Node\Name|string $name Name of the namespace
+     * @param Node\Name|string|null $name Name of the namespace
      */
     public function __construct($name) {
-        $this->name = $this->normalizeName($name);
+        $this->name = null !== $name ? $this->normalizeName($name) : null;
     }
 
     /**
diff --git a/test/PhpParser/Builder/NamespaceTest.php b/test/PhpParser/Builder/NamespaceTest.php
@@ -33,5 +33,9 @@ public function testCreation() {
             ->getNode()
         ;
         $this->assertEquals($expected, $node);
+
+        $node = $this->createNamespaceBuilder(null)->getNode();
+        $this->assertNull($node->name);
+        $this->assertEmpty($node->stmts);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,10 @@ class Namespace_ extends PhpParser\BuilderAbstract`
`14`	`14`	`/**`
`15`	`15`	`* Creates a namespace builder.`
`16`	`16`	`*`
`17`		`- * @param Node\Name\|string $name Name of the namespace`
	`17`	`+ * @param Node\Name\|string\|null $name Name of the namespace`
`18`	`18`	`*/`
`19`	`19`	`public function __construct($name) {`
`20`		`- $this->name = $this->normalizeName($name);`
	`20`	`+ $this->name = null !== $name ? $this->normalizeName($name) : null;`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,9 @@ public function testCreation() {`
`33`	`33`	`->getNode()`
`34`	`34`	`;`
`35`	`35`	`$this->assertEquals($expected, $node);`
	`36`	`+`
	`37`	`+ $node = $this->createNamespaceBuilder(null)->getNode();`
	`38`	`+ $this->assertNull($node->name);`
	`39`	`+ $this->assertEmpty($node->stmts);`
`36`	`40`	`}`
`37`	`41`	`}`