Add a button in prompt to check logs in case the selected interpreter is invalid (microsoft#20642)

Kartik Raj · web-flow · commit fe4c5f1e4ae0 · 2023-02-03T15:02:19.000+05:30
diff --git a/src/client/application/diagnostics/checks/pythonInterpreter.ts b/src/client/application/diagnostics/checks/pythonInterpreter.ts
@@ -34,7 +34,7 @@ const messages = {
         'No Python interpreter is selected. Please select a Python interpreter to enable features such as IntelliSense, linting, and debugging.',
     ),
     [DiagnosticCodes.InvalidPythonInterpreterDiagnostic]: l10n.t(
-        'An Invalid Python interpreter is selected{0}, please try changing it to enable features such as IntelliSense, linting, and debugging.',
+        'An Invalid Python interpreter is selected{0}, please try changing it to enable features such as IntelliSense, linting, and debugging. See output for more details regarding why the interpreter is invalid.',
     ),
 };
 
@@ -163,7 +163,7 @@ export class InvalidPythonInterpreterService extends BaseDiagnosticsService
 
     private getCommandPrompts(diagnostic: IDiagnostic): { prompt: string; command?: IDiagnosticCommand }[] {
         const commandFactory = this.serviceContainer.get<IDiagnosticsCommandFactory>(IDiagnosticsCommandFactory);
-        return [
+        const prompts = [
             {
                 prompt: Common.selectPythonInterpreter,
                 command: commandFactory.createCommand(diagnostic, {
@@ -172,6 +172,16 @@ export class InvalidPythonInterpreterService extends BaseDiagnosticsService
                 }),
             },
         ];
+        if (diagnostic.code === DiagnosticCodes.InvalidPythonInterpreterDiagnostic) {
+            prompts.push({
+                prompt: Common.openOutputPanel,
+                command: commandFactory.createCommand(diagnostic, {
+                    type: 'executeVSCCommand',
+                    options: Commands.ViewOutput,
+                }),
+            });
+        }
+        return prompts;
     }
 }
 
diff --git a/src/test/application/diagnostics/checks/pythonInterpreter.unit.test.ts b/src/test/application/diagnostics/checks/pythonInterpreter.unit.test.ts
@@ -295,7 +295,7 @@ suite('Application Diagnostics - Checks Python Interpreter', () => {
                     ),
                 )
                 .returns(() => cmd)
-                .verifiable(typemoq.Times.once());
+                .verifiable(typemoq.Times.exactly(2));
 
             await diagnosticService.handle([diagnostic]);
 
@@ -304,6 +304,7 @@ suite('Application Diagnostics - Checks Python Interpreter', () => {
             expect(messagePrompt).not.be.equal(undefined, 'Message prompt not set');
             expect(messagePrompt!.commandPrompts).to.be.deep.equal([
                 { prompt: Common.selectPythonInterpreter, command: cmd },
+                { prompt: Common.openOutputPanel, command: cmd },
             ]);
             expect(messagePrompt!.onClose).be.equal(undefined, 'onClose handler should not be set.');
         });
