In newer versions of mxDateTime you cannot compare DateTime objects with strings. This could cause errors in HTTPResponse.setCookie().

Cito · Cito · commit a497d8b2d2fc · 2008-11-13T19:07:50.000Z
diff --git a/WebKit/HTTPResponse.py b/WebKit/HTTPResponse.py
@@ -125,32 +125,30 @@ def setCookie(self, name, value, path='/', expires='ONCLOSE',
 
 		"""
 		cookie = Cookie(name, value)
-		if expires == 'ONCLOSE' or not expires:
-			pass # this is already default behavior
-		elif expires == 'NOW':
-			cookie.delete()
-			return
-		elif expires == 'NEVER':
-			t = time.gmtime(time.time())
-			if expires == 'NEVER':
+		t = expires
+		if type(t) is StringType:
+			if t == 'ONCLOSE':
+				t = None
+			elif t == 'NOW':
+				cookie.delete()
+				return
+			elif t == 'NEVER':
+				t = time.gmtime(time.time())
 				t = (t[0] + 10,) + t[1:]
-			t = time.strftime("%a, %d-%b-%Y %H:%M:%S GMT", t)
-			cookie.setExpires(t)
-		else:
-			t = expires
-			if type(t) is StringType and t and t[0] == '+':
-				interval = timeDecode(t[1:])
-				t = time.time() + interval
+			elif t[0] == '+':
+				t = time.time() + timeDecode(t[1:])
+		if t:
 			if type(t) in (IntType, LongType, FloatType):
 				t = time.gmtime(t)
 			if type(t) in (TupleType, TimeTupleType):
 				t = time.strftime("%a, %d-%b-%Y %H:%M:%S GMT", t)
-			if DateTime and \
-					(type(t) is DateTime.DateTimeDeltaType
-				or isinstance(t, DateTime.RelativeDateTime)):
-				t = DateTime.now() + t
-			if DateTime and type(t) is DateTime.DateTimeType:
-				t = (t - t.gmtoffset()).strftime("%a, %d-%b-%Y %H:%M:%S GMT")
+			if DateTime:
+				if type(t) is DateTime.DateTimeDeltaType or isinstance(
+						t, DateTime.RelativeDateTime):
+					t = DateTime.now() + t
+				if type(t) is DateTime.DateTimeType:
+					t -= t.gmtoffset()
+					t = t.strftime("%a, %d-%b-%Y %H:%M:%S GMT")
 			cookie.setExpires(t)
 		if path:
 			cookie.setPath(path)
diff --git a/WebKit/Testing/SetCookie.py b/WebKit/Testing/SetCookie.py
@@ -1,6 +1,7 @@
 import time
-from WebKit.SidebarPage import SidebarPage
 from MiscUtils import mxDateTime as DateTime
+from WebKit.SidebarPage import SidebarPage
+
 
 cookieValues = [
 	('onclose', 'ONCLOSE'),
