Skip to content

Commit cda41f8

Browse files
bnoordhuistrevnorris
authored andcommitted
src: don't mark addon_register_func as dllimport
addon_register_func and its cousin addon_context_register_func are type definitions, dllimport and dllexport are name mangling directives, i.e. they're quite unrelated concepts. MinGW complains about mixing them when cross-compiling native add-ons. Signed-off-by: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Bert Belder <bertbelder@gmail.com>
1 parent db5abd7 commit cda41f8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/node.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,11 @@ NODE_EXTERN v8::Local<v8::Value> WinapiErrnoException(int errorno,
203203
const char *signo_string(int errorno);
204204

205205

206-
NODE_EXTERN typedef void (*addon_register_func)(
206+
typedef void (*addon_register_func)(
207207
v8::Handle<v8::Object> exports,
208208
v8::Handle<v8::Value> module);
209209

210-
NODE_EXTERN typedef void (*addon_context_register_func)(
210+
typedef void (*addon_context_register_func)(
211211
v8::Handle<v8::Object> exports,
212212
v8::Handle<v8::Value> module,
213213
v8::Handle<v8::Context> context);

0 commit comments

Comments
 (0)