Skip to content

Commit 7a7101a

Browse files
sblomtrevnorris
authored andcommitted
win: fix ObjectWrap for latest v8
We need to keep ObjectWrap around for module authors (we think), but v8 3.21 broke node_object_wrap.h with respect to MSVC. Coincidentally, we no longer use ObjectWrap at all in core, and native modules might as well use their own entirely internal implementation if they need it.
1 parent c137e3d commit 7a7101a

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

src/node_object_wrap.h

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,13 @@
2222
#ifndef SRC_NODE_OBJECT_WRAP_H_
2323
#define SRC_NODE_OBJECT_WRAP_H_
2424

25-
#include "node.h"
2625
#include "v8.h"
2726
#include <assert.h>
2827

29-
// Explicitly instantiate some template classes, so we're sure they will be
30-
// present in the binary / shared object. There isn't much doubt that they will
31-
// be, but MSVC tends to complain about these things.
32-
#ifdef _MSC_VER
33-
template class NODE_EXTERN v8::Persistent<v8::Object>;
34-
template class NODE_EXTERN v8::Persistent<v8::FunctionTemplate>;
35-
#endif
36-
3728

3829
namespace node {
3930

40-
class NODE_EXTERN ObjectWrap {
31+
class ObjectWrap {
4132
public:
4233
ObjectWrap() {
4334
refs_ = 0;

0 commit comments

Comments
 (0)