Use SetPointerInInternalField

ry · ry · commit 5d42cc3a44f8 · 2010-09-09T15:47:37.000-07:00
diff --git a/src/node_object_wrap.h b/src/node_object_wrap.h
@@ -26,8 +26,7 @@ class ObjectWrap {
   {
     assert(!handle.IsEmpty());
     assert(handle->InternalFieldCount() > 0);
-    return static_cast<T*>(v8::Handle<v8::External>::Cast(
-        handle->GetInternalField(0))->Value());
+    return static_cast<T*>(handle->GetPointerFromInternalField(0));
   }
 
   v8::Persistent<v8::Object> handle_; // ro
@@ -38,7 +37,7 @@ class ObjectWrap {
     assert(handle_.IsEmpty());
     assert(handle->InternalFieldCount() > 0);
     handle_ = v8::Persistent<v8::Object>::New(handle);
-    handle_->SetInternalField(0, v8::External::New(this));
+    handle_->SetPointerInInternalField(0, this);
     MakeWeak();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,7 @@ class ObjectWrap {`
`26`	`26`	`{`
`27`	`27`	`assert(!handle.IsEmpty());`
`28`	`28`	`assert(handle->InternalFieldCount() > 0);`
`29`		`- return static_cast<T*>(v8::Handle<v8::External>::Cast(`
`30`		`- handle->GetInternalField(0))->Value());`
	`29`	`+ return static_cast<T*>(handle->GetPointerFromInternalField(0));`
`31`	`30`	`}`
`32`	`31`
`33`	`32`	`v8::Persistent<v8::Object> handle_; // ro`
`@@ -38,7 +37,7 @@ class ObjectWrap {`
`38`	`37`	`assert(handle_.IsEmpty());`
`39`	`38`	`assert(handle->InternalFieldCount() > 0);`
`40`	`39`	`handle_ = v8::Persistent<v8::Object>::New(handle);`
`41`		`- handle_->SetInternalField(0, v8::External::New(this));`
	`40`	`+ handle_->SetPointerInInternalField(0, this);`
`42`	`41`	`MakeWeak();`
`43`	`42`	`}`
`44`	`43`