Skip to content

Commit afa23d7

Browse files
Remove unused ProvisionalFrameProxy.needsMainFrameObserver
https://bugs.webkit.org/show_bug.cgi?id=314874 rdar://177133746 Reviewed by Chris Dumez. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::initializeWebPage): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: Canonical link: https://commits.webkit.org/313331@main
1 parent c57f26e commit afa23d7

2 files changed

Lines changed: 0 additions & 5 deletions

File tree

Source/WebKit/UIProcess/ProvisionalPageProxy.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ ProvisionalPageProxy::ProvisionalPageProxy(WebPageProxy& page, Ref<FrameProcess>
130130
suspendedPage->unsuspend(navigation.targetItem()->mainFrameItem().identifier());
131131
m_mainFrame = suspendedPage->mainFrame();
132132
m_mainFrame->updateReferrerPolicy(ReferrerPolicy::EmptyString);
133-
m_needsMainFrameObserver = true;
134133
} else if (m_shouldReuseMainFrame) {
135134
m_mainFrame = page.mainFrame();
136135
m_mainFrame->updateReferrerPolicy(ReferrerPolicy::EmptyString);
@@ -139,7 +138,6 @@ ProvisionalPageProxy::ProvisionalPageProxy(WebPageProxy& page, Ref<FrameProcess>
139138
// as some clients may rely on it until the next load is committed.
140139
Ref mainFrame = WebFrameProxy::create(page, m_frameProcess, generateFrameIdentifier(), previousMainFrame->effectiveSandboxFlags(), ReferrerPolicy::EmptyString, previousMainFrame->scrollingMode(), nullptr, nullptr, IsMainFrame::Yes, previousMainFrame->url());
141140
m_mainFrame = mainFrame.copyRef();
142-
m_needsMainFrameObserver = true;
143141
previousMainFrame->transferNavigationCallbackToFrame(mainFrame);
144142
}
145143

@@ -273,7 +271,6 @@ void ProvisionalPageProxy::initializeWebPage(RefPtr<API::WebsitePolicies>&& webs
273271
if (m_shouldReuseMainFrame) {
274272
m_webPageID = existingRemotePageProxy->pageID();
275273
m_mainFrame = existingRemotePageProxy->page()->mainFrame();
276-
m_needsMainFrameObserver = false;
277274
m_messageReceiverRegistration.stopReceivingMessages();
278275
m_messageReceiverRegistration.transferMessageReceivingFrom(existingRemotePageProxy->messageReceiverRegistration(), *this, *this);
279276
existingRemotePageProxy->setDrawingArea(nullptr);

Source/WebKit/UIProcess/ProvisionalPageProxy.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ class ProvisionalPageProxy final : public IPC::MessageReceiver, public IPC::Mess
155155

156156
WebPageProxyMessageReceiverRegistration& messageReceiverRegistration() LIFETIME_BOUND { return m_messageReceiverRegistration; }
157157

158-
bool needsMainFrameObserver() const { return m_needsMainFrameObserver; }
159158
void updateFrameProcess();
160159

161160
private:
@@ -232,7 +231,6 @@ class ProvisionalPageProxy final : public IPC::MessageReceiver, public IPC::Mess
232231
bool m_needsCookieAccessAddedInNetworkProcess { false };
233232
bool m_needsDidStartProvisionalLoad { true };
234233
bool m_shouldClosePage { true };
235-
bool m_needsMainFrameObserver { false };
236234
bool m_didFailProvisionalLoad { false };
237235
std::optional<WebCore::Site> m_deferredRemoteTransitionSite;
238236
URL m_provisionalLoadURL;

0 commit comments

Comments
 (0)