Commit 489ea5e

Many independent animated images must finish asynchronous decoding without exhausting decoding workers.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS completedImages is 600

PASS successfullyParsed is true

TEST COMPLETE

<script src="../../resources/js-test.js"></script>

<style>

#images { position: fixed; top: 0; right: 0; display: grid; grid-template-columns: repeat(40, 10px); }

#images img { width: 10px; height: 10px; }

</style>

<div id="images"></div>

<script>

description("Many independent animated images must finish asynchronous decoding without exhausting decoding workers.");

jsTestIsAsync = true;

var completedImages = 0;

(async () => {

internals.clearMemoryCache();

const images = await Promise.all(Array.from({ length: 600 }, async (_, index) => {

const image = new Image;

await new Promise((resolve, reject) => {

image.onload = resolve;

image.onerror = reject;

// Distinct URLs prevent the images from sharing one decoder.

image.src = `resources/animated-red-green-blue-repeat-infinite.gif?concurrent-${index}`;

});

internals.setAsyncDecodingEnabledForTesting(image, true);

return image;

}));

await Promise.all(images.map(image => image.decode()));

for (const image of images)

internals.setImageFrameDecodingDuration(image, 0.05);

document.getElementById("images").append(...images);

document.body.offsetHeight;

testRunner.display();

// Keep the animations visible while all their next-frame requests finish.

await Promise.all(images.map(image => image.decode()));

completedImages = images.filter(image => internals.imageDecodeCount(image) >= 2).length;

shouldBe("completedImages", "600");

})().catch(error => testFailed(String(error))).finally(() => {

document.getElementById("images").remove();

finishJSTest();

});

</script>

Repeatedly removing small batches during animation decoding must not accumulate waiting workers and stall later images.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS completedBatches is 160

PASS successfullyParsed is true

TEST COMPLETE

<script src="../../resources/js-test.js"></script>

<div id="images"></div>

<script>

description("Repeatedly removing small batches during animation decoding must not accumulate waiting workers and stall later images.");

jsTestIsAsync = true;

var completedBatches = 0;

(async () => {

internals.clearMemoryCache();

for (let batch = 0; batch < 160; ++batch) {

const images = await Promise.all(Array.from({ length: 4 }, async (_, index) => {

const image = new Image;

image.decoding = "async";

await new Promise((resolve, reject) => {

image.onload = resolve;

image.onerror = reject;

image.src = `resources/animated-red-green-blue-repeat-1.gif?removed-${batch}-${index}`;

});

internals.setAsyncDecodingEnabledForTesting(image, true);

return image;

}));

await Promise.all(images.map(image => image.decode()));

for (const image of images)

internals.setImageFrameDecodingDuration(image, 0.1);

document.getElementById("images").append(...images);

document.body.offsetHeight;

// Attaching an image can start its timer without requesting a frame.

// Explicitly request the next frame before removing the renderer.

for (const image of images)

internals.resetImageAnimation(image);

const decoding = Promise.all(images.map(image => image.decode()));

await new Promise(resolve => setTimeout(resolve, 5));

if (!images.every(image => internals.imageDecodeCount(image) === 1))

throw new Error("The animation frame must still be decoding when the images are removed.");

document.getElementById("images").replaceChildren();

document.body.offsetHeight;

testRunner.display();

// Wait for this batch to finish before creating another. Only four

// images are attached at once, and earlier batches are not retained.

await decoding;

if (!images.every(image => internals.imageDecodeCount(image) >= 2))

throw new Error("The removed images must finish asynchronous decoding.");

++completedBatches;

}

shouldBe("completedBatches", "160");

})().catch(error => testFailed(String(error))).finally(() => {

document.getElementById("images").remove();

finishJSTest();

});

</script>

std::optional<unsigned> nextFrameIndex;

if (m_frameAnimator && m_frameAnimator->isAnimating())

nextFrameIndex = m_frameAnimator->nextFrameIndex();

// A decoded next frame is still needed while the animation timer is pending.

// Dropping it here would force a synchronous decode when the timer advances.

if (!canDestroyDecodedData && (index == primaryFrameIndex || index == currentFrameIndex || index == nextFrameIndex))

// Keep the decoder while decoded frames are still needed by the image.

if (destroyAll && isDecodingWorkQueueIdle() && !m_decodedSize)

unsigned nextFrameIndex() const { return (m_currentFrameIndex + 1) % m_frameCount; }