Use v8 to test wasm binaries are valid in test suite binary checks (#2206)

kripken · web-flow · commit 256187c823ab · 2019-07-03T15:29:31.000-07:00
diff --git a/.travis.yml b/.travis.yml
@@ -55,7 +55,7 @@ jobs:
         # get jsvu in order to get more js engines
         - npm install jsvu -g
         - export PATH="${HOME}/.jsvu:${PATH}"
-        - jsvu --os=linux64 --engines=spidermonkey
+        - jsvu --os=linux64 --engines=spidermonkey,v8
       script:
         - set -o errexit
         - flake8
diff --git a/check.py b/check.py
@@ -27,7 +27,8 @@
     binary_format_check, delete_from_orbit, fail, fail_with_error,
     fail_if_not_identical, fail_if_not_contained, has_vanilla_emcc,
     has_vanilla_llvm, minify_check, options, tests, requested, warnings,
-    has_shell_timeout, fail_if_not_identical_to_file, with_pass_debug
+    has_shell_timeout, fail_if_not_identical_to_file, with_pass_debug,
+    validate_binary
 )
 
 # For shared.num_failures. Cannot import directly because modifications made in
@@ -189,6 +190,8 @@ def check():
 
       with_pass_debug(check)
 
+      validate_binary(t)
+
 
 def run_crash_tests():
   print "\n[ checking we don't crash on tricky inputs... ]\n"
@@ -380,7 +383,7 @@ def fix_actual(x):
             o.write(module + '\n' + '\n'.join(asserts))
           run_spec_test('split.wast')  # before binary stuff - just check it's still ok split out
           run_opt_test('split.wast')  # also that our optimizer doesn't break on it
-          result_wast = binary_format_check('split.wast', verify_final_result=False)
+          result_wast = binary_format_check('split.wast', verify_final_result=False, original_wast=wast)
           # add the asserts, and verify that the test still passes
           open(result_wast, 'a').write('\n' + '\n'.join(asserts))
           actual += run_spec_test(result_wast)
diff --git a/scripts/fuzz_opt.py b/scripts/fuzz_opt.py
@@ -21,7 +21,7 @@
 import shutil
 import time
 
-from test.shared import options, NODEJS
+from test.shared import options, NODEJS, V8_OPTS
 
 
 # parameters
@@ -32,18 +32,6 @@
 
 FUZZ_OPTS = []
 
-V8_OPTS = [
-  '--experimental-wasm-eh',
-  '--experimental-wasm-mv',
-  '--experimental-wasm-sat-f2i-conversions',
-  '--experimental-wasm-se',
-  '--experimental-wasm-threads',
-  '--experimental-wasm-simd',
-  '--experimental-wasm-anyref',
-  '--experimental-wasm-bulk-memory',
-  '--experimental-wasm-return-call'
-]
-
 INPUT_SIZE_LIMIT = 150 * 1024
 
 LOG_LIMIT = 125
diff --git a/scripts/test/shared.py b/scripts/test/shared.py
@@ -157,6 +157,7 @@ def is_exe(fpath):
             which('g++') or which('clang++'))
 NODEJS = os.getenv('NODE', which('nodejs') or which('node'))
 MOZJS = which('mozjs') or which('spidermonkey')
+V8 = which('v8') or which('d8')
 EMCC = which('emcc')
 
 BINARYEN_INSTALL_DIR = os.path.dirname(options.binaryen_bin)
@@ -190,7 +191,13 @@ def wrap_with_valgrind(cmd):
   ASM2WASM = wrap_with_valgrind(ASM2WASM)
   WASM_SHELL = wrap_with_valgrind(WASM_SHELL)
 
-os.environ['BINARYEN'] = os.getcwd()
+
+def in_binaryen(*args):
+  __rootpath__ = os.path.abspath(os.path.dirname(os.path.dirname(os.path.dirname(__file__))))
+  return os.path.join(__rootpath__, *args)
+
+
+os.environ['BINARYEN'] = in_binaryen()
 
 
 def get_platform():
@@ -204,6 +211,19 @@ def has_shell_timeout():
   return get_platform() != 'windows' and os.system('timeout 1s pwd') == 0
 
 
+# Default options to pass to v8. These enable all features.
+V8_OPTS = [
+  '--experimental-wasm-eh',
+  '--experimental-wasm-mv',
+  '--experimental-wasm-sat-f2i-conversions',
+  '--experimental-wasm-se',
+  '--experimental-wasm-threads',
+  '--experimental-wasm-simd',
+  '--experimental-wasm-anyref',
+  '--experimental-wasm-bulk-memory',
+  '--experimental-wasm-return-call'
+]
+
 has_vanilla_llvm = False
 
 # external tools
@@ -377,8 +397,18 @@ def fail_if_not_identical_to_file(actual, expected_file):
 
 # check utilities
 
+
+def validate_binary(wasm):
+  if V8:
+    cmd = [V8] + V8_OPTS + [in_binaryen('scripts', 'validation_shell.js'), '--', wasm]
+    print '      ', ' '.join(cmd)
+    subprocess.check_call(cmd, stdout=subprocess.PIPE)
+  else:
+    print '(skipping v8 binary validation)'
+
+
 def binary_format_check(wast, verify_final_result=True, wasm_as_args=['-g'],
-                        binary_suffix='.fromBinary'):
+                        binary_suffix='.fromBinary', original_wast=None):
   # checks we can convert the wast to binary and back
 
   print '     (binary format check)'
@@ -389,6 +419,13 @@ def binary_format_check(wast, verify_final_result=True, wasm_as_args=['-g'],
   subprocess.check_call(cmd, stdout=subprocess.PIPE)
   assert os.path.exists('a.wasm')
 
+  # make sure it is a valid wasm, using a real wasm VM
+  if os.path.basename(original_wast or wast) not in [
+    'atomics.wast',  # https://bugs.chromium.org/p/v8/issues/detail?id=9425
+    'simd.wast',  # https://bugs.chromium.org/p/v8/issues/detail?id=8460
+  ]:
+    validate_binary('a.wasm')
+
   cmd = WASM_DIS + ['a.wasm', '-o', 'ab.wast']
   print '      ', ' '.join(cmd)
   if os.path.exists('ab.wast'):
diff --git a/scripts/validation_shell.js b/scripts/validation_shell.js
@@ -0,0 +1,28 @@
+// Test a file is valid, by just loading it.
+
+// Shell integration.
+if (typeof console === 'undefined') {
+  console = { log: print };
+}
+var binary;
+if (typeof process === 'object' && typeof require === 'function' /* node.js detection */) {
+  var args = process.argv.slice(2);
+  binary = require('fs').readFileSync(args[0]);
+  if (!binary.buffer) binary = new Uint8Array(binary);
+} else {
+  var args;
+  if (typeof scriptArgs != 'undefined') {
+    args = scriptArgs;
+  } else if (typeof arguments != 'undefined') {
+    args = arguments;
+  }
+  if (typeof readbuffer === 'function') {
+    binary = new Uint8Array(readbuffer(args[0]));
+  } else {
+    binary = read(args[0], 'binary');
+  }
+}
+
+// Test the wasm for validity by compiling it.
+new WebAssembly.Module(binary);
+
diff --git a/test/badvartype.wasm b/test/badvartype.wasm
diff --git a/test/badvartype.wasm.fromBinary b/test/badvartype.wasm.fromBinary
