Skip to content

Commit 250608a

Browse files
committed
added suggestions for code style
changed indentation to 4 spaces for java and added hint how to configure XML formatting Signed-off-by: brandstaetter <hannes.mueller@gmail.com>
1 parent e0575bf commit 250608a

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

development/eclipse/biojava-checkstyle.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,5 @@ Checkstyle configuration that checks the biojava coding conventions.
8282
<module name="NewlineAtEndOfFile"/>
8383
<module name="Translation"/>
8484
<module name="FileLength"/>
85-
<module name="FileTabCharacter">
86-
<property name="severity" value="ignore"/>
87-
<metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/>
88-
</module>
85+
<module name="FileTabCharacter"/>
8986
</module>

development/eclipse/biojava-formatter.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
<setting id="org.eclipse.jdt.core.formatter.alignment_for_superclass_in_type_declaration" value="16"/>
9090
<setting id="org.eclipse.jdt.core.formatter.alignment_for_assignment" value="0"/>
9191
<setting id="org.eclipse.jdt.core.compiler.problem.assertIdentifier" value="error"/>
92-
<setting id="org.eclipse.jdt.core.formatter.tabulation.char" value="tab"/>
92+
<setting id="org.eclipse.jdt.core.formatter.tabulation.char" value="space"/>
9393
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_constructor_declaration_parameters" value="insert"/>
9494
<setting id="org.eclipse.jdt.core.formatter.insert_space_after_semicolon_in_try_resources" value="insert"/>
9595
<setting id="org.eclipse.jdt.core.formatter.insert_space_before_prefix_operator" value="do not insert"/>

development/hints.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ Set up your development environment (assuming the use of Eclipse) as follows:
1919
* Add missing '@Deprecated' annotations
2020
* Remove unnecessary casts
2121
* Remove unnecessary '$NON-NLS$' tags
22-
* Remove trailing white spaces on all lines
22+
* Remove trailing white spaces on all lines
23+
* configure XML formatting in `Preferences > XML > XML Files > Editor`
24+
* Line width: `120`
25+
* Format comments (and join lines)
26+
* Insert whitespace before closing empty end-tags
27+
* Indent using `2` spaces
2328
* install the Checkstyle Plugin and import `biojava-checkstyle.xml`
2429
* (install the Findbugs Plugin)

0 commit comments

Comments
 (0)