Don't mutate class attribute (temporalio#115)

dandavison · web-flow · commit bcb983607b3e · 2024-05-23T10:00:29.000-04:00
- Comment out unused imports
diff --git a/encryption/codec.py b/encryption/codec.py
@@ -1,4 +1,3 @@
-import base64
 import os
 from typing import Iterable, List
 
diff --git a/hello/hello_activity.py b/hello/hello_activity.py
@@ -1,5 +1,4 @@
 import asyncio
-import logging
 from dataclasses import dataclass
 from datetime import timedelta
 
@@ -38,7 +37,8 @@ async def run(self, name: str) -> str:
 
 
 async def main():
-    # Uncomment the line below to see logging
+    # Uncomment the lines below to see logging output
+    # import logging
     # logging.basicConfig(level=logging.INFO)
 
     # Start client
diff --git a/hello/hello_mtls.py b/hello/hello_mtls.py
@@ -5,7 +5,8 @@
 from typing import Optional
 
 from temporalio import activity, workflow
-from temporalio.client import Client, TLSConfig
+from temporalio.client import Client
+from temporalio.service import TLSConfig
 from temporalio.worker import Worker
 
 
diff --git a/hello/hello_patch.py b/hello/hello_patch.py
@@ -1,5 +1,4 @@
 import asyncio
-import logging
 import sys
 from dataclasses import dataclass
 from datetime import timedelta
@@ -96,7 +95,8 @@ async def main():
 
     version = sys.argv[1]
 
-    # Uncomment the line below to see logging
+    # Uncomment the lines below to see logging output
+    # import logging
     # logging.basicConfig(level=logging.INFO)
 
     # Start client
diff --git a/hello/hello_search_attributes.py b/hello/hello_search_attributes.py
@@ -1,10 +1,7 @@
 import asyncio
-from typing import List
 
 from temporalio import workflow
-from temporalio.client import Client, WorkflowExecutionDescription
-from temporalio.common import SearchAttributeValues
-from temporalio.converter import default as default_converter
+from temporalio.client import Client
 from temporalio.worker import Worker
 
 
diff --git a/hello/hello_update.py b/hello/hello_update.py
@@ -7,7 +7,8 @@
 
 @workflow.defn
 class GreetingWorkflow:
-    is_complete = False
+    def __init__(self):
+        self.is_complete = False
 
     @workflow.run
     async def run(self) -> str:

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import base64`
`2`	`1`	`import os`
`3`	`2`	`from typing import Iterable, List`
`4`	`3`