Skip to content

Commit 0d754f5

Browse files
authored
fix typos (fastplotlib#991)
* fix typos * add rendercanvas to intersphinx_mapping
1 parent 5721c9b commit 0d754f5

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

docs/source/conf.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,5 +134,6 @@
134134
"numpy": ("https://numpy.org/doc/stable", None),
135135
"pygfx": ("https://docs.pygfx.org/stable", None),
136136
"wgpu": ("https://wgpu-py.readthedocs.io/en/latest", None),
137+
"rendercanvas": ("https://rendercanvas.readthedocs.io/stable/", None),
137138
# "fastplotlib": ("https://www.fastplotlib.org/", None),
138139
}

docs/source/developer_notes/graphics.rst

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,14 @@ For example let's look at ``LineGraphic`` in ``fastplotlib/graphics/line.py``. E
5656
``"data", "colors", "cmap", "thickness"`` in addition to properties common to all graphics, such as ``"name", "offset", "rotation", and "visible"``
5757

5858
Now look at the constructor for the ``LineGraphic`` base class ``PositionsGraphic``, it first creates an instance of ``VertexPositions``.
59-
This is a class that manages vertex positions buffer. For the user, it defines the line data, and provides additional useful functionality.
60-
It defines the line, and provides additional useful functionality.
59+
This is a class that manages vertex positions buffer. For the user, it defines the line vertex positions, and provides additional useful functionality.
6160
For example, every time that the ``data`` is changed, the new data will be marked for upload to the GPU before the next draw.
6261
In addition, event handlers will be called if any event handlers are registered.
6362

64-
``VertexColors`` behaves similarly, but it can perform additional parsing that can create the colors buffer from different
63+
``VertexColors`` behaves similarly, but it can perform additional parsing that can create or set the colors buffer from different
6564
forms of user input. For example if a user runs: ``line_graphic.colors = "blue"``, then ``VertexColors.__setitem__()`` will
66-
create a buffer that corresponds to what ``pygfx.Color`` thinks is "blue". Users can also take advantage of fancy indexing,
67-
ex: ``line_graphics.colors[bool_array] = "red"`` 😊
65+
set the buffer that corresponds to what ``pygfx.Color`` thinks is "blue", i.e the RGBA array `[0, 0, 1, 1]. Users can also take advantage of fancy indexing,
66+
ex: ``line_graphics.colors[bool_array] = "red"`` 😊 to set the color of specific vertices.
6867

6968
``LineGraphic`` also has a ``VertexCmap``, this manages the line ``VertexColors`` instance to parse colormaps, for example:
7069
``line_graphic.cmap = "jet"`` or even ``line_graphic.cmap[50:] = "viridis"``.
@@ -73,4 +72,4 @@ ex: ``line_graphics.colors[bool_array] = "red"`` 😊
7372
callbacks to indicate that the graphic has been deleted (for example, removing references to a graphic from a legend).
7473

7574
Other graphics have properties that are relevant to them, for example ``ImageGraphic`` has ``cmap``, ``vmin``, ``vmax``,
76-
properties unique to images.
75+
properties unique to images.

0 commit comments

Comments
 (0)