Reject non-object JSON request bodies cleanly - #3458
Draft
adamtheturtle wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3391.
What
Reject valid JSON values that are not objects during the common JSON validation step. Expand the existing invalid-JSON integration test across arrays, strings, numbers,
null, and booleans.Why
Downstream validators assume a mapping and previously leaked
AttributeErrororTypeError, producing exceptions or HTTP 500 responses instead of a VWS error.Checks
POST /targetscasesuv run --extra=dev prek run --files src/mock_vws/_services_validators/json_validators.py tests/mock_vws/test_invalid_json.py